Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use sdk v0.46.7-regen and register amino #1694

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

ryanchristo
Copy link
Member

Description

Ref: regen-network/cosmos-sdk#49

This pull request updates to the forked version of v0.46.7 (v0.46.7-regen-1), which includes gov and group amino support.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1694 (a5c0c81) into main (3f7a601) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1694      +/-   ##
==========================================
+ Coverage   72.80%   72.81%   +0.01%     
==========================================
  Files         228      228              
  Lines       13600    13608       +8     
==========================================
+ Hits         9901     9909       +8     
  Misses       2967     2967              
  Partials      732      732              
Impacted Files Coverage Δ
x/ecocredit/base/types/v1/codec.go 100.00% <100.00%> (ø)
x/ecocredit/basket/types/v1/codec.go 100.00% <100.00%> (ø)
x/ecocredit/marketplace/types/v1/codec.go 100.00% <100.00%> (ø)
x/intertx/types/v1/codec.go 100.00% <100.00%> (ø)

@ryanchristo ryanchristo marked this pull request as ready for review December 16, 2022 03:35
@ryanchristo ryanchristo requested a review from a team December 16, 2022 03:35
@ryanchristo ryanchristo added the backport/v5.0.x backport to release/v5.0.x branch label Dec 16, 2022
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ryanchristo ryanchristo merged commit 4d94494 into main Dec 16, 2022
@ryanchristo ryanchristo deleted the ryan/sdk-v046-regen branch December 16, 2022 16:14
mergify bot pushed a commit that referenced this pull request Dec 16, 2022
ryanchristo added a commit that referenced this pull request Dec 16, 2022
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.0.x backport to release/v5.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants