Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining group events #302

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Add remaining group events #302

merged 2 commits into from
Mar 31, 2021

Conversation

blushi
Copy link
Member

@blushi blushi commented Mar 19, 2021 •
edited by zube bot
Loading

closes: #215

@codecov
Copy link

codecov bot commented Mar 19, 2021 •
edited
Loading

Codecov Report

Merging #302 (5ad0d6b) into master (a38ebdb) will decrease coverage by 0.08%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   62.25%   62.17%   -0.09%     
==========================================
  Files          47       47              
  Lines        2994     3003       +9     
==========================================
+ Hits         1864     1867       +3     
- Misses        911      914       +3     
- Partials      219      222       +3

@blushi blushi marked this pull request as ready for review March 19, 2021 09:54
amaury1093
amaury1093 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

aleem1314
aleem1314 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blushi blushi merged commit 2666989 into master Mar 31, 2021
@blushi blushi deleted the marie/215-group-events branch March 31, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@atheeshp atheeshp atheeshp approved these changes

@aleem1314 aleem1314 aleem1314 approved these changes

@anilcse anilcse Awaiting requested review from anilcse

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

@likhita-809 likhita-809 Awaiting requested review from likhita-809

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@technicallyty technicallyty Awaiting requested review from technicallyty

Assignees

@aleem1314 aleem1314

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[x/group] Events
4 participants
@blushi @amaury1093 @atheeshp @aleem1314