Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually set credit class fee #591

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fix: manually set credit class fee #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### General

#### Fixed

* [#591](https://github.com/regen-network/regen-ledger/pull/591) Set credit class fee in upgrade handler

## [v2.0.0-beta1](https://github.com/regen-network/regen-ledger/releases/tag/v2.0.0-beta1) - 2021-08-19

### General
Expand Down
2 changes: 2 additions & 0 deletions app/experimental_appconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
//go:build experimental
// +build experimental
Comment on lines +1 to 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like go 1.17 prefers //go:build lines over // +build now (https://golang.org/doc/go1.17)

Should we drop the second line then? Or is the redundancy ok?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to have both. The redundancy is ok:

all Go files should be updated to have both forms with the same meaning


// DONTCOVER

package app
Expand Down
3 changes: 3 additions & 0 deletions app/stable_appconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
//go:build !experimental
ryanchristo marked this conversation as resolved.
Show resolved Hide resolved
// +build !experimental

// DONTCOVER

package app
Expand Down Expand Up @@ -76,6 +78,7 @@ func (app *RegenApp) registerUpgradeHandlers() {

gen := ecocredittypes.DefaultGenesisState()
gen.Params.AllowlistEnabled = true
gen.Params.CreditClassFee = sdk.NewCoins(sdk.NewCoin("uregen", ecocredittypes.DefaultCreditClassFeeTokens))
technicallyty marked this conversation as resolved.
Show resolved Hide resolved

modules := make(map[string]json.RawMessage)
modules[ecocredittypes.ModuleName] = app.cdc.MustMarshalJSON(gen)
Expand Down
1 change: 1 addition & 0 deletions app/testsuite/network_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build norace
ryanchristo marked this conversation as resolved.
Show resolved Hide resolved
// +build norace

package testsuite_test
Expand Down