feat: add add-to-basket cli command #750
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,3 +15,9 @@ message BasketCredit { | |
| // credit type for this batch. | ||
| string amount = 2; | ||
| } | ||
|
|
||
| // BasketCredits represents the slice of BasketCredit objects. | ||
| message BasketCredits { | ||
| // credits is the list of basket credits | ||
| repeated BasketCredit credits = 1; | ||
| } | ||
|
There was a problem hiding this comment. I believe we want changes to proto definitions merged into master and backported to the release branch. We will need to add this addition to master as well, correct? @aaronc @technicallyty @robert-zaremba There was a problem hiding this comment. I think we can do either way (unless there is a change in state.proto). Those backports needs to be done manually.
ryanchristo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way to do this without adding this to the proto file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second that. Lets don't pollute proto if the only thing we want is to parse helper structure in CLI. And we also don't need proto JSON marshaller for that. The
stdlibshould work.In the
client/basketpackage we can just do:so the JSON in the file is an array (without
{ "credits": ...})