Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): Put basket server method #758
feat(x/ecocredit): Put basket server method #758
Changes from 19 commits
f2ee929
df7beb5
411bc14
e2e7712
68b9ca8
97cc155
7ed4262
563a27c
201a00f
0b6536a
52d37ff
6498166
5b28eb2
a2c57a6
43570f9
67be2de
670b740
98f752f
f45f638
69c3cb9
c210657
ed06ec2
d327c24
0db3736
2572114
221d9b5
ad2665e
61fa847
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a comment that
key[0]
is a storage prefix.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comment explaining format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get Set, Add ... Decimal functions are general - how about moving it outside of ecocrerdits? At least, let's move them to different package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is mostly code that was already there and will be going way soon in #723 so I don't think we to spend that much effort on cleanup. agreed a different package makes sense generally...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we can just do that when/if the times comes when another package needs it? this move was just a fix for import cycles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i'd say keep as is because it's all getting deleted right after the 2.2 release