Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-309 batch denom name in getCancelCardItems function #2489

Merged

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Oct 1, 2024

Description

https://regennetwork.atlassian.net/browse/APP-309

This PR also correct/updates the title in the cancel confirmation modal.


Author Checklist

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Go to https://deploy-preview-2489--regen-marketplace.netlify.app/storefront and verify that on cancel sell order modal the displayed batch denom is the same as the one the link points to.
  2. Verify that the cancel sell order modal title is: "Are you sure you want to cancel this sell order?"

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 3543b44
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66fd462e1881ed0008088cf2
😎 Deploy Preview https://deploy-preview-2489--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph r41ph requested a review from blushi October 1, 2024 12:43
@r41ph
Copy link
Contributor Author

r41ph commented Oct 1, 2024

@erikalogie have a look when you get a chance please

@erikalogie
Copy link
Collaborator

@r41ph I'm having trouble creating a sell order on this branch to be able to test this with.

Nothing happens when I click the button:

Screen.Recording.2024-10-01.at.9.11.00.AM.mov

@r41ph
Copy link
Contributor Author

r41ph commented Oct 1, 2024

@erikalogie I have added the preview domain to the Wallet connect cloud. Can you try again to see if it works?
After a chat with @blushi this is not the case tho :)

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@r41ph r41ph force-pushed the fix-APP-309-hardcoded-batch-denom-on-cancel-modal-storefront branch from 393e448 to 3543b44 Compare October 2, 2024 13:10
@r41ph r41ph merged commit 1f30605 into dev Oct 2, 2024
14 checks passed
@r41ph r41ph deleted the fix-APP-309-hardcoded-batch-denom-on-cancel-modal-storefront branch October 2, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants