Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-342 user profile certificate multiple denom #2533

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Nov 5, 2024

Description

https://regennetwork.atlassian.net/browse/APP-341
https://regennetwork.atlassian.net/browse/APP-342

This PR also removes the Retirement reason heading from the retirement certificate if the user hasn't added a reason.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

https://deploy-preview-2533--regen-marketplace.netlify.app/

  1. Verify that the Retirement Certificates table shows multiple batch IDs when in retirements from more that one batch - https://deploy-preview-2533--regen-marketplace.netlify.app/dashboard/portfolio
  2. Verify the Retirement certificates shows the Credit batch/es at the bottom of the certificate
  3. Verify that certificates don't show the Retirement reason heading if the user hasn't added a reason when buying credits.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit cb21d58
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/674d999c4870700008ae5856
😎 Deploy Preview https://deploy-preview-2533--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph r41ph force-pushed the feat-APP-342-user-profile-certificate-multiple-denom branch 2 times, most recently from 24d8f08 to 709876c Compare November 6, 2024 09:00
@r41ph
Copy link
Contributor Author

r41ph commented Nov 6, 2024

@erikalogie see testing instructions

@r41ph r41ph requested a review from blushi November 6, 2024 09:04
@r41ph
Copy link
Contributor Author

r41ph commented Nov 6, 2024

@r41ph
Copy link
Contributor Author

r41ph commented Nov 7, 2024

@erikalogie as discussed I've added support for all the dropdowns to work together in each row and fixed the alignment issues in Brave, please have a look

@erikalogie
Copy link
Collaborator

LGTM!

@r41ph r41ph force-pushed the feat-APP-342-user-profile-certificate-multiple-denom branch from 9ffe49c to cb21d58 Compare December 2, 2024 11:27
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit cb21d58
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/674d999c441bb40008bdd97c
😎 Deploy Preview https://deploy-preview-2533--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph r41ph requested a review from blushi December 2, 2024 11:34
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r41ph r41ph merged commit 16eed46 into dev Dec 2, 2024
18 checks passed
@r41ph r41ph deleted the feat-APP-342-user-profile-certificate-multiple-denom branch December 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants