Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-502 tebu factors small UI issues #2563

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Nov 27, 2024

Description

https://regennetwork.atlassian.net/browse/APP-502


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@blushi blushi requested a review from r41ph November 27, 2024 09:15
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 5c1cab7
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/674ef3afc32eda00085080ad
😎 Deploy Preview https://deploy-preview-2563--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 5c1cab7
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/674ef3afebd92700088adae0
😎 Deploy Preview https://deploy-preview-2563--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Nov 27, 2024

@erikalogie
Copy link
Collaborator

LGTM

@S4mmyb
Copy link
Member

S4mmyb commented Nov 27, 2024

@blushi this looks good, but I'm noticing that in Spanish the text describing project length remains in English.

image

@blushi
Copy link
Member Author

blushi commented Nov 28, 2024

@blushi this looks good, but I'm noticing that in Spanish the text describing project length remains in English.

image

This is now fixed @S4mmyb

@blushi blushi force-pushed the fix-APP-502-tebu-factors-small-ui branch from c5e5a6e to e84d134 Compare December 3, 2024 11:42
@blushi blushi merged commit f97c1c7 into dev Dec 3, 2024
18 checks passed
@blushi blushi deleted the fix-APP-502-tebu-factors-small-ui branch December 3, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants