Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-413 Show project admin from offchain data on project page #2584

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

blushi
Copy link
Member

@blushi blushi commented Jan 22, 2025

Description

https://regennetwork.atlassian.net/browse/APP-413


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit a36993e
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/6798a618dbb422000822b098
😎 Deploy Preview https://deploy-preview-2584--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested a review from r41ph January 22, 2025 09:18
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit a36993e
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6798a61802f9f00008427542
😎 Deploy Preview https://deploy-preview-2584--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Jan 22, 2025

@erikalogie @S4mmyb see testing instructions

@erikalogie
Copy link
Collaborator

Should we change this tooltip for offchain projects? Or make it sufficiently generic to work for both on and offchain projects?

Screenshot 2025-01-22 at 1 19 10 PM

@S4mmyb
Copy link
Member

S4mmyb commented Jan 23, 2025

Should we change this tooltip for offchain projects? Or make it sufficiently generic to work for both on and offchain projects?

I think we should remove it for off-chain projects if we keep that text. Alternatively (which might actually be better), we update the tooltip text on both to something like, "The entity responsible for technical management, editing project content, and managing participant access for contributions and updates."

@erikalogie
Copy link
Collaborator

Should we change this tooltip for offchain projects? Or make it sufficiently generic to work for both on and offchain projects?

I think we should remove it for off-chain projects if we keep that text. Alternatively (which might actually be better), we update the tooltip text on both to something like, "The entity responsible for technical management, editing project content, and managing participant access for contributions and updates."

I like using the same tooltip text on both, maybe we can shorten your suggestion just a bit like so: " The entity responsible for technical management, content editing, and managing participant access for contributions."

@S4mmyb
Copy link
Member

S4mmyb commented Jan 23, 2025

Should we change this tooltip for offchain projects? Or make it sufficiently generic to work for both on and offchain projects?

I think we should remove it for off-chain projects if we keep that text. Alternatively (which might actually be better), we update the tooltip text on both to something like, "The entity responsible for technical management, editing project content, and managing participant access for contributions and updates."

I like using the same tooltip text on both, maybe we can shorten your suggestion just a bit like so: " The entity responsible for technical management, content editing, and managing participant access for contributions."

That's perfect!

@blushi blushi force-pushed the fix-APP-413-offchain-project-admin branch from 97307a5 to 6df2ba4 Compare January 27, 2025 08:35
@blushi
Copy link
Member Author

blushi commented Jan 27, 2025

@S4mmyb @erikalogie I've updated the project admin tooltip

@erikalogie
Copy link
Collaborator

@blushi LGTM

@S4mmyb
Copy link
Member

S4mmyb commented Jan 27, 2025

+1, thanks @blushi

@blushi blushi force-pushed the fix-APP-413-offchain-project-admin branch from 6df2ba4 to a36993e Compare January 28, 2025 09:40
@blushi blushi enabled auto-merge (squash) January 28, 2025 09:40
@blushi blushi merged commit 94400c0 into dev Jan 28, 2025
15 of 18 checks passed
@blushi blushi deleted the fix-APP-413-offchain-project-admin branch January 28, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants