Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send regen #779

Merged
merged 10 commits into from
Oct 26, 2021
Merged

Send regen #779

merged 10 commits into from
Oct 26, 2021

Conversation

mhagel
Copy link
Contributor

@mhagel mhagel commented Oct 15, 2021

Closes: regen-network/rnd-dev-team#695
Closes: #769

To test:

  • Attach Keplr wallet.
  • In a project page, click Buy Credits.
  • The credit counter widget selects how many REGEN to send to test wallet regen18hj7m3skrsrr8lfvwqh66r7zruzdvp6ylwxrx4 (as a POC)
  • click "Purchase" and confirm in Keplr
  • If successful, there will be a transaction hash alert, which can be checked in block explorer (if it is working)

Note:

  • to get this to work with an http RPC endpoint in the deploy preview, we are proxying the request through registry-server-staging. So far, it looks like this breaks the "View on Ledger" functionality (I changed the endpoint to Hambach), but this may be resolved when the block explorer is fixed?

@mhagel mhagel force-pushed the mark/695-send-REGEN branch from 1e62e6c to c111470 Compare October 18, 2021 19:12
@mhagel mhagel force-pushed the mark/695-send-REGEN branch from 9e77b18 to cf62489 Compare October 20, 2021 13:15
@mhagel mhagel changed the title DRAFT: Mark/695 send regen Send regen Oct 20, 2021
@mhagel mhagel requested a review from blushi October 20, 2021 20:58
@blushi
Copy link
Member

blushi commented Oct 21, 2021

to get this to work with an http RPC endpoint in the deploy preview, we are proxying the request through registry-server-staging. So far, it looks like this breaks the "View on Ledger" functionality (I changed the endpoint to Hambach), but this may be resolved when the block explorer is fixed?

The "View on ledger" feature has nothing to do with the block explorer working or not. The issue is actually that staging is still using tx hashes from the previous devnet! I'll update them in the staging db to use the new ones.

@blushi
Copy link
Member

blushi commented Oct 21, 2021

@mhagel @erikalogie Another way to test that the transfer's been successful while the block explorer is down is to go to http://147.182.238.116:26657/tx?hash=0x{HASH} and replace {HASH} with the tx hash (don't forget the 0x at the beginning), eg http://147.182.238.116:26657/tx?hash=0x97B20AEC7FD074A3F89B40C21F7F5853414800ED70D44AC9D676EA36E148DE85

@blushi
Copy link
Member

blushi commented Oct 21, 2021

It doesn't like it's working with a Ledger Nano, could you create a follow-up issue to support that? @mhagel

@mhagel
Copy link
Contributor Author

mhagel commented Oct 21, 2021

@blushi

It doesn't like it's working with a Ledger Nano, could you create a follow-up issue to support that? @mhagel

Yes: #783

@mhagel mhagel requested a review from haveanicedavid October 25, 2021 19:20
Copy link
Contributor

@haveanicedavid haveanicedavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting way of using context to pass a stateful method - I like it

@mhagel
Copy link
Contributor Author

mhagel commented Oct 26, 2021

Interesting way of using context to pass a stateful method - I like it

Yeah, it seemed simple enough.

@mhagel mhagel merged commit 20a83dd into master Oct 26, 2021
@mhagel mhagel deleted the mark/695-send-REGEN branch October 26, 2021 04:40
@mhagel mhagel modified the milestone: Hawk Oct 26, 2021
keplr?: Keplr;
}
// eslint-disable-next-line @typescript-eslint/no-empty-interface
interface Window extends KeplrWindow {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using Window instead of just KeplrWindow here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keplr - use recommended Typescript types Send REGEN tokens with Keplr wallet to Registry test address
3 participants