Improve error messages and handling of cargo manifest #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated) This also gives us some workspace support (you need to choose a target from workspace) Improves #8 but only by not crashing on workspaces. We still show one target. The current assumption of one lib max fails when running in a workspace. Since the current code does not allow to select a specific lib target Also there are more target kinds than bin and lib that might be interesting to parse. We should revist the user experience here or always show the whole workspace.
muhuk
reviewed
Jun 9, 2019
muhuk
reviewed
Jun 9, 2019
Cargo versions might not generated the same order of targets or similar issues leading to hard to fix test failures
muhuk
approved these changes
Jun 11, 2019
There was a problem hiding this comment.
This is going to mess up my long running branch but I'm willing to rebase/redo. I think overall this is a good patch.
Thanks for removing the system call from the unit tests. Also thanks for removing muhuk directory from the manifests. It was bothering me a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed errror messages when not in cargo project to fix Fails to parse JSON when it's not a rust project #37
Refactor to use cargo metadata instead of cargo read-manifest (deprecated)
This also gives us some workspace support (you need to choose a target from workspace)
Improves Support for cargo workspaces #8 but only by not crashing on workspaces. We still show one target.
The current assumption of one lib max fails when running in a workspace.
Since the current code does not allow to select a specific lib target
Also there are more target kinds than bin and lib that might be interesting to parse.
We should revist the user experience here or always show the whole workspace.