Skip to content

Commit

Permalink
chore(commitlint): add config file to commitlint (#5)
Browse files Browse the repository at this point in the history
## What this PR does / why we need it:
<!--
What code changes are made?
What problem does this PR addresses, or what feature this PR adds?
-->
`commitlint` action fails after merging some PRs due to the body length
limit. We do not care about that, especially for the PRs created by
renovate. Preserving PR details in the commit is more important. Thus
adding the config disabling this particular rule.

## Which issue(s) this PR resolves:
<!--
Usage: `Resolves #<issue number>`, or `Resolves <link to the issue>`.
If PR is about `failing-tests`, please post the related tests in a
comment and do not use `Resolves`
-->
Resolves issues with merge commits (body line length error).

## Special notes for your reviewer:
<!-- Do you think reviewers should focus on any particular parts of
code? -->
N/A

## Additional documentation e.g., enhancement proposals, usage docs,
etc.:
<!-- This section can be blank if this pull request does not require a
release note. -->
<!-- REPLACE WITH CONTENT -->

---------

Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
  • Loading branch information
shanduur committed Apr 13, 2024
1 parent 16655bc commit 731c78b
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .commitlintrc.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export default {
extends: ['@commitlint/config-conventional'],
rules: {
'body-max-line-length': [0],
},
}
3 changes: 2 additions & 1 deletion .github/workflows/linters-tests.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: linters-tests-image
name: linters-tests

on:
pull_request:
Expand All @@ -19,6 +19,7 @@ jobs:
fetch-depth: 0
- uses: wagoid/commitlint-github-action@v5
with:
configFile: .commitlintrc.mjs
token: ${{ secrets.GITHUB_TOKEN }}

linters:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/semantic-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
requireScope: true
subjectPattern: ^(?![A-Z]).+$
subjectPattern: ^(?![A-Z]).+$
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ repos:
- id: conventional-pre-commit
stages: [commit-msg]
- repo: https://github.com/norwoodj/helm-docs
rev: v1.12.0
rev: v1.13.1
hooks:
- id: helm-docs
args:
- '--badge-style=flat'
- repo: https://github.com/koalaman/shellcheck-precommit
rev: v0.9.0
rev: v0.10.0
hooks:
- id: shellcheck
4 changes: 4 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"automerge": true,
"extends": [ "config:recommended" ],
"labels": [ "area/dependency" ],
"pre-commit": {
"enabled": true
},
"vulnerabilityAlerts": {
"enabled": true
}
Expand Down

0 comments on commit 731c78b

Please sign in to comment.