Skip to content

Commit

Permalink
Change AxisSettings livezone default (bevyengine#10090)
Browse files Browse the repository at this point in the history
# Objective

While using joysticks for player aiming, I noticed that there was as
`0.05` value snap on the axis. After searching through Bevy's code, I
saw it was the default livezone being at `0.95`. This causes any value
higher to snap to `1.0`. I think `1.0` and `-1.0` would be a better
default, as it gives all values to the joystick arc.
 
This default livezone stumped me for a bit as I thought either something
was broken or I was doing something wrong.

## Solution

Change the livezone defaults to ` livezone_upperbound: 1.0` and
`livezone_lowerbound: -1.0`.

---

## Migration Guide

If the default 0.05 was relied on, the default or gamepad `AxisSettings`
on the resource `GamepadSettings` will have to be changed.
  • Loading branch information
100-TomatoJuice authored and Thomas Wilgenbus committed Oct 13, 2023
1 parent c362e5b commit a3694ac
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions crates/bevy_input/src/gamepad.rs
Original file line number Diff line number Diff line change
Expand Up @@ -631,10 +631,10 @@ pub struct AxisSettings {
impl Default for AxisSettings {
fn default() -> Self {
AxisSettings {
livezone_upperbound: 0.95,
livezone_upperbound: 1.0,
deadzone_upperbound: 0.05,
deadzone_lowerbound: -0.05,
livezone_lowerbound: -0.95,
livezone_lowerbound: -1.0,
threshold: 0.01,
}
}
Expand Down Expand Up @@ -1529,7 +1529,7 @@ mod tests {
];

for (new_value, expected) in cases {
let settings = AxisSettings::default();
let settings = AxisSettings::new(-0.95, -0.05, 0.05, 0.95, 0.01).unwrap();
test_axis_settings_filter(settings, new_value, None, expected);
}
}
Expand All @@ -1556,7 +1556,7 @@ mod tests {
];

for (new_value, old_value, expected) in cases {
let settings = AxisSettings::default();
let settings = AxisSettings::new(-0.95, -0.05, 0.05, 0.95, 0.01).unwrap();
test_axis_settings_filter(settings, new_value, old_value, expected);
}
}
Expand Down

0 comments on commit a3694ac

Please sign in to comment.