Support overriding more keys via resources #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks @jblosser ! I also don't see how there would be an issue with Sway but will test it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This PR makes more of the modifier keys for container and workspace movement and modification configurable via resources. So for example I can swap 'Ctrl' as the workspace 11-19 selector and 'Shift' as the move-container-to-workspace key.
I've tested this locally using i3; I don't have a sway setup but I doubt it's any different.
This also provides a fix for #3, though the "carry window to workspace" case is a bit odd because it uses
$altand AFAICT I can't access that directly from the default argument inset_from_resource, so it has to be set directly as Mod1 here.Added:
wm.workspace.high.key for the key to reach workspaces 11-19 (default is Ctrl)
wm.move_container_to_ws_key to move containers to workspaces (default is Shift)
wm.carry_container_to_ws_key to move containers to workspaces and change to that workspace (default is Mod1)
These names aren't necessarily consistent with each other, but I tried to keep them consistent with the ones around them. Obviously they can be changed to whatever.