Add inherit options #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rehanone
requested changes
Jul 16, 2022
|
@rehanone I'm not sure why my build is failing now but I have squashed my commits. Any suggestions? |
|
It looks like one of the tests is failing: ` It is inside file spec/share_spec.rb line 46. Hope that helps. |
|
@rehanone I modified the test so it is working as expected now. Would you like me to squash into one commit again before merging? |
|
Yes please 😊 |
|
@rehanone Should be good to go now! |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inherit owner and inherit permissions share options.