Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom types in favor of Puppetlabs Stdlib Stdlib::Ensure::Package #50

Merged
merged 1 commit into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions REFERENCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@
* [`samba::option`](#samba--option): Manages smb.conf options.
* [`samba::share`](#samba--share): == Define samba::share

### Data types

* [`Samba::InstallType`](#Samba--InstallType)
* [`Samba::PackageState`](#Samba--PackageState)

## Classes

### <a name="samba"></a>`samba`
Expand Down Expand Up @@ -107,7 +102,7 @@ Should this module manage the installation/removal of the $packages?

##### <a name="-samba--package_ensure"></a>`package_ensure`

Data type: `Samba::PackageState`
Data type: `Stdlib::Ensure::Package`

The installation state of $packages.

Expand Down Expand Up @@ -489,7 +484,7 @@ Default value: `$samba::package_manage`

##### <a name="-samba--client--package_ensure"></a>`package_ensure`

Data type: `Samba::PackageState`
Data type: `Stdlib::Ensure::Package`

The installation state of the Samba client package

Expand Down Expand Up @@ -864,23 +859,3 @@ The absent/present state of the key/value parameter.

Default value: `present`

## Data types

### <a name="Samba--InstallType"></a>`Samba::InstallType`

The Samba::InstallType data type.

Alias of

```puppet
Struct[{
ensure => Samba::PackageState,
}]
```

### <a name="Samba--PackageState"></a>`Samba::PackageState`

The Samba::PackageState data type.

Alias of `Enum[present, absent, purged, disabled, installed, latest]`

2 changes: 1 addition & 1 deletion manifests/client.pp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
utils => Array[String[1]],
}] $packages = $samba::packages,
Boolean $package_manage = $samba::package_manage,
Samba::PackageState $package_ensure = $samba::package_ensure,
Stdlib::Ensure::Package $package_ensure = $samba::package_ensure,
) {
if $package_manage {
package { $packages[client]:
Expand Down
2 changes: 1 addition & 1 deletion manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
utils => Array[String[1]],
}] $packages,
Boolean $package_manage,
Samba::PackageState $package_ensure,
Stdlib::Ensure::Package $package_ensure,
String $config_file,
String $config_lens,
Variant[Enum[mask, manual], Boolean] $service_enable,
Expand Down
2 changes: 1 addition & 1 deletion metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"dependencies": [
{
"name": "puppetlabs-stdlib",
"version_requirement": ">= 6.0.0 < 9.0.0"
"version_requirement": ">= 8.6.0 < 9.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stdlib::Ensure::Package first introduced.

},
{
"name": "puppetlabs-augeas_core",
Expand Down
28 changes: 0 additions & 28 deletions spec/type_aliases/packagestate_spec.rb

This file was deleted.

3 changes: 0 additions & 3 deletions types/installtype.pp

This file was deleted.

8 changes: 0 additions & 8 deletions types/packagestate.pp

This file was deleted.