Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Workflow Improvements and Fixes #1056

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Conversation

SergeyShorokhov
Copy link
Member

@SergeyShorokhov SergeyShorokhov commented Oct 15, 2024

CI Workflow Improvements and Fixes

This pull request introduces several key changes to improve the CI pipeline in the rehlds repository, addressing compatibility issues, standardizing CI processes, and optimizing artifact handling.

Fixes

  • Node.js Compatibility Issue Resolution
    • Updated action versions and dependencies to run on *-latest OS versions, fixing failures caused by outdated Node.js versions incompatible with legacy actions. Updated container configurations for build and test demos to match this requirement.

Changes

  • Action Updates

    • Upgraded the checkout action to version 4 and upload-artifact/download-artifact actions to version 4 for more consistent and secure artifact management.
  • Demo Testing Enhancements

    • Migrated to ubuntu-latest for demo tests and updated the container to rehldsorg/testdemos:latest.
    • Simplified the demo testing setup by using a matrix strategy with runTest.sh for efficient test execution.
  • Linux Dependency Management

    • Standardized the installation of required libraries to streamline dependencies across Linux jobs.
  • Consistent CI Standard Across Repositories

    • Unified the CI approach with other repositories (e.g., rehlds, regamedll) to ensure a consistent workflow structure.

Impact

These updates improve the CI workflow's reliability, maintainability, and simplify artifact management, ensuring smoother contributions across all related repositories.

refer:

@SergeyShorokhov SergeyShorokhov added Type: 🛠️ maintenance Tasks related to technical debt, infrastructure upkeep. Type: 🛑 dependency Routine tasks, maintenance, or non-user-facing changes. labels Oct 15, 2024
@SergeyShorokhov SergeyShorokhov self-assigned this Oct 15, 2024
@SergeyShorokhov SergeyShorokhov force-pushed the fix/testdemos-new-image branch 3 times, most recently from 6fde7f7 to 1bd6b79 Compare October 17, 2024 15:12
@SergeyShorokhov SergeyShorokhov force-pushed the fix/testdemos-new-image branch 4 times, most recently from 6fb793c to e36b503 Compare October 18, 2024 11:03
@SergeyShorokhov SergeyShorokhov marked this pull request as draft October 18, 2024 12:37
@SergeyShorokhov SergeyShorokhov force-pushed the fix/testdemos-new-image branch 2 times, most recently from 93ea4ef to 7a4c192 Compare October 18, 2024 13:35
@SergeyShorokhov SergeyShorokhov marked this pull request as ready for review October 18, 2024 14:11
@SergeyShorokhov SergeyShorokhov added the Status: 🕹️ on hold Task temporarily on hold. label Oct 28, 2024
@SergeyShorokhov

This comment was marked as outdated.

@SergeyShorokhov SergeyShorokhov changed the title New testdemos image: rehldsorg/testdemos:latest CI Workflow Improvements and Fixes Oct 29, 2024
@SergeyShorokhov SergeyShorokhov added Priority: 🔥 high Tasks with high priority that require immediate attention. and removed Status: 🕹️ on hold Task temporarily on hold. labels Oct 29, 2024
@SergeyShorokhov SergeyShorokhov merged commit 5a1f66a into master Oct 29, 2024
7 checks passed
@SergeyShorokhov SergeyShorokhov deleted the fix/testdemos-new-image branch October 29, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 🔥 high Tasks with high priority that require immediate attention. Type: 🛑 dependency Routine tasks, maintenance, or non-user-facing changes. Type: 🛠️ maintenance Tasks related to technical debt, infrastructure upkeep.
Projects
None yet
2 participants