Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when keys dynamically change and re-render, localState is stale. The following example demonstrates this currently:
This pull request fixes this by basically adding the key as a dependency to each useEffect/useCallback, and adding an effect that rehydrates localState when the key changes with whatever the actual value is.
I also wrote a test in
test/index.test.tsx
to ensure it works. Current tests don't catch a staleonLocalStorageChange useCallback
at the moment either - worth noting.Finally - I apologies for the handful of formatting changes - there is no
.prettierrc
file to enforce code style.Let me know if you have any questions! Cheers for the great plugin otherwise.