Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use npm workspaces #67

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Use npm workspaces #67

merged 1 commit into from
Aug 26, 2021

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Leverage npm's built in workspaces feature https://docs.npmjs.com/cli/v7/using-npm/workspaces to manage the monorepo.

@ChristianMurphy ChristianMurphy added the 🏗 area/tools This affects tooling label Aug 25, 2021
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 25, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@wooorm
Copy link
Member

wooorm commented Aug 26, 2021

This line should fix Erbium:

https://github.com/remarkjs/remark-lint/blob/909d9cceea9007b8d4029c89c2209f428880914b/.github/workflows/main.yml#L14

wooorm
wooorm reviewed Aug 26, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ChristianMurphy ChristianMurphy force-pushed the build/migrate-lerna-to-npm-workspaces branch from c96e41c to 200bada Compare August 26, 2021 13:27
@ChristianMurphy ChristianMurphy force-pushed the build/migrate-lerna-to-npm-workspaces branch from 200bada to 41a7ff6 Compare August 26, 2021 13:37
@wooorm wooorm changed the title build: migrate lerna to npm workspaces Use npm workspaces Aug 26, 2021
@wooorm wooorm merged commit 4f64443 into rehypejs:main Aug 26, 2021
@ChristianMurphy ChristianMurphy deleted the build/migrate-lerna-to-npm-workspaces branch August 26, 2021 13:48
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 26, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 26, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing approved these changes

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🏗 area/tools This affects tooling 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristianMurphy @codecov-commenter @wooorm @remcohaszing