Fix/lead #163
Merged
Fix/lead #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhewson
reviewed
Dec 13, 2023
| @@ -19,7 +19,10 @@ const style = useCssModule(); | |||
| > | |||
| <slot /> | |||
| </CdrHeadingDisplay> | |||
| <CdrSubheadingSans :class="style[`${baseClass}__subheading`]"> | |||
| <CdrSubheadingSans | |||
There was a problem hiding this comment.
one question I have is around nesting the subhead span in the header - I think we may want to pass this by accessibility. I like the pattern but am also thinking that the heading may have a char limit for screen readers?
There was a problem hiding this comment.
I think it's okay, I used a similar pattern on the cedar doc site and ran it by @daemoncron.
mhewson
approved these changes
Dec 13, 2023
| @@ -25,7 +25,6 @@ const baseClass = 'cdr-lead' | |||
|
|
|||
| <template> | |||
| <div :class="style[baseClass]"> | |||
| <div :class="style[`${baseClass}__top`]" /> | |||
| <div | |||
| v-if="imgSrc" | |||
There was a problem hiding this comment.
still question if this should be picture - I guess as a srcset can just be used in image this is fine?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.