UT Osiris 2023-09-11 #8847
Merged
UT Osiris 2023-09-11 #8847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
other-files-updated
|
Thanks!
So it still seems it doesn't merge automatically. Do you know why? I do
leave clicked, "Allow edits by maintainers".
Susan
…On Mon, Sep 11, 2023 at 10:30 AM Alvaro J. Castro Rivadeneira < ***@***.***> wrote:
Merged #8847 <#8847>
into master.
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX56ZGRRL27ZF7NH35LLXZ44BNANCNFSM6AAAAAA4TSVKTM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
|
Hi Susan - yes, I noticed it, too. I'm not sure, and will ask my colleagues to see if they have any ideas. |
|
Thanks so much!
…On Mon, Sep 11, 2023 at 10:33 AM Alvaro J. Castro Rivadeneira < ***@***.***> wrote:
Hi Susan - yes, I noticed it, too. I'm not sure, and will ask my
colleagues to see if they have any ideas.
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX52L46CQFVFED57VYGLXZ44M5ANCNFSM6AAAAAA4TSVKTM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi Susan. The problem is that you were adding the files in the wrong location. They were added to the base directory of the repository rather than in |
|
Thanks and sorry about this. I'll try this next week.
…On Mon, Sep 11, 2023 at 11:32 AM Alvaro J. Castro Rivadeneira < ***@***.***> wrote:
Hi Susan. The problem is that you were adding the files in the wrong
location. They were added to the base directory of the repository rather
than in data-processed/UT-Osiris. I fixed the issue, and moved the files
to the correct location. For next week, just make sure to submit the files
in the correct location. Thanks and have a good week.
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX544JF7WAV7RUC6XF2TXZ5DKTANCNFSM6AAAAAA4TSVKTM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No problem. I'll be more careful as well. |
|
Dear Alvaro,
The final stage of merging still seems to not be happening automatically
(or at least taking a lot longer than previously). No errors
were reported. I believe I put the files in the right place. Any ideas?
Thanks!
Susan
…On Mon, Sep 11, 2023 at 12:17 PM Alvaro J. Castro Rivadeneira < ***@***.***> wrote:
No problem. I'll be more careful as well.
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX57LSOUTSYNUHO7LPKTXZ5IVLANCNFSM6AAAAAA4TSVKTM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi Susan, I'm glad the validations worked this week, and that seems to be in order. I suspect the reason your pull request is not merging automatically is because your fork has not been updated. To be clear, your fork seems to be 80 commits behind the master branch.
Here is how you would update the branch:
Perhaps if you do that before submitting your pull request next week it will solve the problem? Let's give it a try, as I think that has been a problem for other teams in the past. Have a good week and let me know if you have more questions or concerns. Kind regards, |
|
Ahh...thank you. I'll try that.
I took over submitting from someone else and I think this step didn't get
passed on (I don't use github regularly).
I figured out the flipped images -- thanks.
Thanks again for all your help!
Susan
On Mon, Sep 18, 2023 at 11:57 AM Alvaro J. Castro Rivadeneira <
***@***.***> wrote:
… Hi Susan, I just commented directly on GitHub but wanted to mention my
initial comment had the image order reversed. I fixed it, but just wanted
to let you know in case you got it as an email and it was confusing. Have
a
good day.
On Mon, Sep 18, 2023 at 1:32 PM SusanPtak ***@***.***> wrote:
> Dear Alvaro,
>
> The final stage of merging still seems to not be happening automatically
> (or at least taking a lot longer than previously). No errors
> were reported. I believe I put the files in the right place. Any ideas?
>
> Thanks!
> Susan
>
> On Mon, Sep 11, 2023 at 12:17 PM Alvaro J. Castro Rivadeneira <
> ***@***.***> wrote:
>
> > No problem. I'll be more careful as well.
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <
>
#8847 (comment)>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/A2JHX57LSOUTSYNUHO7LPKTXZ5IVLANCNFSM6AAAAAA4TSVKTM>
>
> > .
> > You are receiving this because you authored the thread.Message ID:
> > ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Freichlab%2Fcovid19-forecast-hub%2Fpull%2F8847%23issuecomment-1724058846&data=05%7C01%7Cacastrorivad%40umass.edu%7C6c3fe63130e54ac1b0f408dbb86d3ccf%7C7bd08b0b33954dc194bbd0b2e56a497f%7C0%7C0%7C638306551531134597%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=WRWTfHi8Wy0WR%2FQyp1qp42zfjem0%2Bqv0Y235IyrcIUc%3D&reserved=0>,
> or unsubscribe
> <
https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FANOWHDTHBETVFRKCFFNZJDLX3CAS5ANCNFSM6AAAAAA4TSVKTM&data=05%7C01%7Cacastrorivad%40umass.edu%7C6c3fe63130e54ac1b0f408dbb86d3ccf%7C7bd08b0b33954dc194bbd0b2e56a497f%7C0%7C0%7C638306551531134597%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Dl7%2FzjtNH4Aslc2vX6E%2BFM3jjdj2YGJCNnx5xiE%2B1lw%3D&reserved=0>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX52DHS57XMRJTUZH2JDX3CDSBANCNFSM6AAAAAA4TSVKTM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No problem! Hope it all goes well. |
|
Dear Alvaro,
I'm trying to submit again (our new submission person was out of town for
the holiday). I've uploaded the new forecast to my fork, but when I go to
commit changes it says "Processing your files... This may take a few
minutes to complete", but it never seems to complete, even after waiting a
few minutes. Any ideas?
Thanks!
Susan
…On Mon, Sep 18, 2023 at 12:51 PM Alvaro J. Castro Rivadeneira < ***@***.***> wrote:
No problem! Hope it all goes well.
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX544WSTKPHQIWQEGQHTX3CJ3HANCNFSM6AAAAAA4TSVKTM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Dear Susan, there is at least one team that had a problem with their submission, which eventually resolved on its own (maybe it was a GitHub issue?). Regarding your November 27 submission, there are two separate items:
|
Closed
|
Dear Alvaro,
Thank you so much! My suspicion is I was having a GitHub issue, but
perhaps you are right, that someone/some program recognized that both of us
were trying to submit (I did try to do it not at the same time as he, but
perhaps his account wasn't as closed out as it should be). And indeed my
co-worker was having the problems you saw: I think when he initially ran
the code he forgot to update the date, which caused the initial failure
(and of course he was still traveling from the holiday break which makes
everything harder), and in all his attempts to fix things, also managed to
upload a file to the wrong location at some point. Once he was back we
could work together and fix the date and get rid of the extra file, and
have now successfully submitted.
Thank you again for all your help.
Susan
…On Mon, Nov 27, 2023 at 1:45 PM Alvaro J. Castro Rivadeneira < ***@***.***> wrote:
Dear Susan, there is at least one team that had a problem with their
submission, which eventually resolved on its own (maybe it was a GitHub
issue?). Regarding your November 27 submission, there are two separate
items:
1. The "processing your files" delay may be a GitHub issue, or perhaps
it's related to a separate UT Osiris submission by @michaelsegzy
<https://github.com/michaelsegzy> today.
2. The other submission by @michaelsegzy
<https://github.com/michaelsegzy> has at least two problems I can see:
(a) there are two files which are being submitted in this PR
<https://github.com/reichlab/covid19-forecast-hub/pull/9034/files> -
one is in the wrong location. (b) I looked at the actual file, and although
the name changed, the predictions still seem to be for last week.
My suggestion is to close that PR. Just clean your branch and try to
re-submit.
I hope that works!
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX5ZTAXB4PCZ7XUVFWW3YGT3XHAVCNFSM6AAAAAA4TSVKTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGU3TIMRUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I'm glad the submission worked. It's often difficult to discover the source of these problems. Have a good week! |
|
Thanks. You too!
…On Mon, Nov 27, 2023 at 2:50 PM Alvaro J. Castro Rivadeneira < ***@***.***> wrote:
I'm glad the submission worked. It's often difficult to discover the
source of these problems. Have a good week!
—
Reply to this email directly, view it on GitHub
<#8847 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2JHX53YDDJWZGQBWLKMMXDYGUDJVAVCNFSM6AAAAAA4TSVKTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGY3TKNJTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Please include your team name in the title of the pull request. Thank you!