Support implicit namespaces #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Python 3.3 one does not need to create `__init__.py` files to mark a folder to be part of a namespace, but the simple presence of a python file deep inside it is enough to create it. Moreover, since `setuptools` 62.3.0 it is officially discouraged to use the old `pkg_resources` namespace technique.
gforcada
force-pushed
the
support-implicit-namespaces
branch
from
a126ead
to
22b780e
Compare
|
May I merge and release then? 😄 I'm never comfortable doing that without asking and getting approval 😅 But given that plenty of packages are configured with |
|
Release is fine.
Reinout
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #120
Seems that all the discussion we had with @ericof at the issue is not so relevant, as we are already using the
.egg-infoinformation to know where the source code is located 🎉