Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PATH entry of de-installed SDKs persists #10

Open
reitzig opened this issue Jul 14, 2018 · 2 comments
Open

PATH entry of de-installed SDKs persists #10

reitzig opened this issue Jul 14, 2018 · 2 comments
Labels
blocked bug Something isn't working

Comments

@reitzig
Copy link
Owner

reitzig commented Jul 14, 2018

After uninstalling all versions of a candidate, fish greets us with an error:

set: Warning: $PATH entry "/home/raphael/.sdkman/candidates/crash/current/bin" is not valid (No such file or directory)
Welcome to fish, the friendly interactive shell
@reitzig
Copy link
Owner Author

reitzig commented Jul 14, 2018

SDKMAN! doesn't seem to remove the candidate folder itself:

$ tree .sdkman/candidates/crash/
.sdkman/candidates/crash/

0 directories, 0 files

reitzig added a commit that referenced this issue Jul 14, 2018
@reitzig
Do not add uninstalled SDKs to PATH.
debd5e2 
Fixes issue #10 pt1.
reitzig added a commit that referenced this issue Jul 14, 2018
@reitzig
Do not add uninstalled SDKs to PATH on startup.
8ca5354 
Fixes issue #10 pt1.
@reitzig reitzig self-assigned this Jul 14, 2018
@reitzig reitzig added the bug Something isn't working label Jul 14, 2018
@reitzig
Copy link
Owner Author

reitzig commented Jul 14, 2018 •
edited

We no longer try to add removed candidates to PATH of new shells.

sdk uninstall does not change the PATH of the current shell; this is a bug in SDKMAN! and won't be worked around here. A test exists on branch issue-10; waiting for a fix upstream. Tracked as sdkman/sdkman-cli#662.

@reitzig reitzig closed this as completed Jul 14, 2018
reitzig added a commit that referenced this issue Nov 6, 2019
@reitzig
Adds test documenting upstream bug in SDKMAN!
5c1226f 
cf. issue #10
@reitzig reitzig reopened this Nov 6, 2019
@reitzig reitzig added the blocked label Nov 6, 2019
@reitzig reitzig removed their assignment Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reitzig