Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with macOS #29

Closed
reitzig opened this issue Jul 30, 2019 · 4 comments
Closed

Make compatible with macOS #29

reitzig opened this issue Jul 30, 2019 · 4 comments
Assignees
@reitzig
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@reitzig
Copy link
Owner

reitzig commented Jul 30, 2019

Due to differences in default programs, sdkman-for-fish currently doesn't work on macOS. Issues include

  • non-GNU stat (see also this comment),
  • sha256sum unavailable (test only).

We'll need tests and then see what we can do about whatever pops up.
@reitzig reitzig added enhancement New feature or request help wanted Extra attention is needed labels Jul 30, 2019
reitzig added a commit that referenced this issue Jul 30, 2019
@reitzig
issue #29 - Make Travis test on macOS.
93aaabd 
And mercy be with us all.

 - Use `apt` and `homebrew` addons for simplicity and build speed (?).
 - Make build matrix explicit: can't handle installing different
   versions of fish otherwise.
This was referenced Jul 30, 2019
Closed
Closed
reitzig added a commit that referenced this issue Jul 30, 2019
@reitzig
issue #29 - Make Travis test on macOS.
2e6335e 
And mercy be with us all.

 - Use `apt` and `homebrew` addons for simplicity and build speed (?).
 - Make build matrix explicit: can't handle installing different
   versions of fish otherwise.
reitzig added a commit that referenced this issue Jul 30, 2019
@reitzig
issue #29 - Make Travis test on macOS.
da69b50 
And mercy be with us all.

 - Use `apt` and `homebrew` addons for simplicity and build speed (?).
 - Make build matrix explicit: can't handle installing different
   versions of fish otherwise.
@reitzig
Copy link
Owner Author

reitzig commented Jul 30, 2019 •
edited
Loading

While the fish 2.7.1 formula exists, curl as called by Travis doesn't find it; Homebrew became homebrew. D'oh? This fails the test with fish 2 right at the start.

reitzig added a commit that referenced this issue Jul 30, 2019
@reitzig
issue #29 - Add macOS alternative for sha256sum.
b1887e4
reitzig added a commit that referenced this issue Jul 31, 2019
@reitzig
issue #29: Replace stat with something more portable.
12f7d3d 
cf. https://unix.stackexchange.com/a/7732/17409
@reitzig
Copy link
Owner Author

reitzig commented Aug 1, 2019

In test/completions.rb, we're getting:

find: -printf: unknown primary or operator

There's another red test:

  Testing 'sdk use ant 1.9.9 > /dev/null; sdk broadcast'
  - sout ok!
  - status ok!
  - path bad:
    7a8
    > /Users/travis/.sdkman/candidates/ant/current/bin
  - anthome bad:
    1c1
    < /Users/travis/.sdkman/candidates/ant/1.9.9
    ---
    > /Users/travis/.sdkman/candidates/ant/current

@reitzig reitzig mentioned this issue Aug 31, 2019
Closed
@krishnan-mani krishnan-mani mentioned this issue Sep 30, 2019
Closed
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: avoid find -printf on macOS
ed505a6
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Avoid GNU-specific find.
fa004ba
@reitzig reitzig self-assigned this Nov 5, 2019
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Avoid GNU-specific find.
7faecfd
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Local Homebrew formula for fish 2
a77b5d3
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Local Homebrew formula for fish 2
f94c704
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Local Homebrew formula for fish 2
c6b324a
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Local Homebrew formula for fish 2
0d42de6
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Fix installation test.
1c88e68
reitzig added a commit that referenced this issue Nov 5, 2019
@reitzig
issue #29: Fix installation test.
7e9d8a7
@reitzig
Copy link
Owner Author

reitzig commented Nov 5, 2019 •
edited
Loading

One test remains red:

  Testing 'sdk use ant 1.9.9 > /dev/null; sdk broadcast'
  - sout ok!
  - status ok!
  - path bad:
    7a8
    > /Users/travis/.sdkman/candidates/ant/current/bin
  - anthome bad:
    1c1
    < /Users/travis/.sdkman/candidates/ant/1.9.9
    ---
    > /Users/travis/.sdkman/candidates/ant/current

This tastes suspiciously like a reincarnation of #19 -- but only on macOS? Does the workaround maybe not work there?

reitzig added a commit that referenced this issue Nov 6, 2019
@reitzig
Final macOS incompatibility fix.
ac99d14 
Closes issue #29.
@reitzig
Copy link
Owner Author

reitzig commented Nov 6, 2019

Turns out it was exactly that, due to sed behaving differently on macOS.

Seems that was the last of it -- ship it!

PS: Developing for macOS without a Mac ... sucks.

@reitzig reitzig closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reitzig reitzig

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reitzig