fix variable problems (MagicMirrorOrg#3304)

related to MagicMirrorOrg#3302 - fix MM_PORT variable not used in electron - fix to allow full path for MM_CONFIG_FILE variable
rejas · Dec 28, 2023 · a927eb2 · a927eb2
1 parent aad3eef
commit a927eb2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -50,6 +50,7 @@ _This release is scheduled to be released on 2024-01-01._
 - Fix style issues after prettier update
 - Fix calendar test (#3291) by moving "Exdate check" from e2e to electron to run on a Thursday
 - Fix calendar config params `fetchInterval` and `excludedEvents` were never used from single calendar config (#3297)
+- Fix MM_PORT variable not used in electron and allow full path for MM_CONFIG_FILE variable (#3302)
 
 ## [2.25.0] - 2023-10-01
 

diff --git a/js/app.js b/js/app.js
@@ -25,7 +25,7 @@ Log.log(`Starting MagicMirror: v${global.version}`);
 global.root_path = path.resolve(`${__dirname}/../`);
 
 if (process.env.MM_CONFIG_FILE) {
-	global.configuration_file = process.env.MM_CONFIG_FILE;
+	global.configuration_file = process.env.MM_CONFIG_FILE.replace(`${global.root_path}/`, "");
 }
 
 // FIXME: Hotfix Pull Request

diff --git a/js/electron.js b/js/electron.js
@@ -79,7 +79,8 @@ function createWindow () {
 	}
 
 	let address = (config.address === void 0) | (config.address === "") | (config.address === "0.0.0.0") ? (config.address = "localhost") : config.address;
-	mainWindow.loadURL(`${prefix}${address}:${config.port}`);
+	const port = process.env.MM_PORT || config.port;
+	mainWindow.loadURL(`${prefix}${address}:${port}`);
 
 	// Open the DevTools if run with "npm start dev"
 	if (process.argv.includes("dev")) {