feat(eddsa): Added EDDSA crypto module #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added EDDSA(25519 curve) crypto module to the framework. Current design for eddsa module is messy, this PR is a starting point to take this activity. Need to discuss with others.
This is an attempt at making the MultiSignature type be generic so that impl can be switched at the top level instead of nested.
While converting the quorum signature from proto, initialization of the multi signature is causing type conversion failures in the crypto modules.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 61.67% 62.52% +0.85%
==========================================
Files 77 79 +2
Lines 7433 7576 +143
==========================================
+ Hits 4584 4737 +153
+ Misses 2548 2537 -11
- Partials 301 302 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
meling
requested changes
Mar 9, 2024
Addressed review comments except for the comment in keygen.go file, as it would add a switch case in the orchestration layer. Tried to add more cases, this mock layer is not very flexible to add more negative cases.
We now use ed25519.PublicKey directly instead of []byte. The ed25519.PublicKey is a type alias for []byte, but it is best to use the correct type.
meling
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EDDSA(25519 curve) crypto module to the framework.
The current design for eddsa module is messy, this PR is a starting point to take this activity.
Need to discuss with others.