style(ui): Fix PropTypes

relative-ci · Nov 15, 2019 · af79834 · af79834
1 parent 43ff7f4
commit af79834
Show file tree

Hide file tree

Showing 11 changed files with 17 additions and 3,560 deletions.
diff --git a/packages/html-templates/build/storybook/__snapshots__/storyshots.test.js.snap b/packages/html-templates/build/storybook/__snapshots__/storyshots.test.js.snap
diff --git a/packages/ui/build/storybook/__snapshots__/storyshots.test.js.snap b/packages/ui/build/storybook/__snapshots__/storyshots.test.js.snap
diff --git a/...ges/ui/src/components/bundle-assets-totals-chart-bars/bundle-assets-totals-chart-bars.jsx b/...ges/ui/src/components/bundle-assets-totals-chart-bars/bundle-assets-totals-chart-bars.jsx
@@ -79,7 +79,7 @@ export const BundleAssetsTotalsChartBars = ({ className, jobs }) => {
 
           return (
             <div
-              key={internalBuildNumber}
+              key={internalBuildNumber || runIndex}
               className={css.item}
             >
               <h3 className={css.itemTitle}>

diff --git a/packages/ui/src/components/duplicate-packages-warning/duplicate-packages-warning.jsx b/packages/ui/src/components/duplicate-packages-warning/duplicate-packages-warning.jsx
@@ -21,7 +21,7 @@ export const DuplicatePackagesWarning = (props) => {
               {key}
             </p>
             <ul className={css.itemPackages}>
-              {paths.map((path) => <li>{path}</li>)}
+              {paths.map((path) => <li key={path}>{path}</li>)}
             </ul>
           </li>
         ))}

diff --git a/packages/ui/src/components/jobs-header/jobs-header.jsx b/packages/ui/src/components/jobs-header/jobs-header.jsx
@@ -52,7 +52,7 @@ export const JobsHeader = (props) => {
         const { builtAt, hash } = get(job, `meta.${SOURCE_PATH_WEBPACK_STATS}`, {});
 
         return (
-          <div className={css.job} key={job.internalBuilNumber}>
+          <div className={css.job} key={job.internalBuilNumber || index}>
             <div className={css.jobDescription}>
               <h1 className={css.jobTitle}>
                 <span>

diff --git a/packages/ui/src/components/summary-item/summary-item.jsx b/packages/ui/src/components/summary-item/summary-item.jsx
@@ -91,6 +91,7 @@ SummaryItem.defaultProps = {
   className: '',
   data: null,
   size: 'medium',
+  loading: false,
   showMetricDescription: false,
   showBaselineValue: false,
   showDelta: true,
@@ -107,7 +108,7 @@ SummaryItem.propTypes = {
   id: PropTypes.string.isRequired,
 
   /** Loading flag */
-  loading: PropTypes.bool.isRequired,
+  loading: PropTypes.bool,
 
   /** Summary data */
   data: PropTypes.object, // eslint-disable-line react/forbid-prop-types

diff --git a/packages/ui/src/ui/alert/alert.jsx b/packages/ui/src/ui/alert/alert.jsx
@@ -17,7 +17,7 @@ export const Alert = (props) => {
 Alert.propTypes = {
   className: PropTypes.string,
   kind: PropTypes.string,
-  children: PropTypes.oneOfType([PropTypes.string, PropTypes.element]).isRequired,
+  children: PropTypes.node.isRequired,
 };
 
 Alert.defaultProps = {

diff --git a/packages/ui/src/ui/icon/icon.jsx b/packages/ui/src/ui/icon/icon.jsx
@@ -49,5 +49,5 @@ Icon.defaultProps = {
 Icon.propTypes = {
   className: PropTypes.string,
   glyph: PropTypes.string.isRequired,
-  as: PropTypes.oneOfType([PropTypes.string, PropTypes.element, PropTypes.func]),
+  as: PropTypes.node,
 };
diff --git a/packages/ui/src/ui/icon/icon.stories.jsx b/packages/ui/src/ui/icon/icon.stories.jsx
@@ -22,6 +22,6 @@ stories.add('all', () => (
     'pr',
     'sort',
   ].map((glyph) => (
-    <Icon glyph={glyph} />
+    <Icon glyph={glyph} key={glyph} />
   ))
 ));
diff --git a/packages/ui/src/ui/table/table.jsx b/packages/ui/src/ui/table/table.jsx
@@ -81,7 +81,7 @@ export const Table = ({
 
         return (
           <tr className={rowClassNames} key={key || index} {...rowProps}>
-            {header && renderHeader(header)}
+            {header ? renderHeader(header) : null}
             {cells.map((cell, cellIndex) => {
               const cellProps = {
                 key: (cell && cell.key) || cellIndex,

diff --git a/packages/ui/src/ui/tooltip/tooltip.jsx b/packages/ui/src/ui/tooltip/tooltip.jsx
@@ -24,24 +24,27 @@ export const Tooltip = (props) => {
       {...restProps}
     >
       {children}
-      <div className={css.tooltip}>
-        {title}
-        <span className={css.tooltipArrow} />
-      </div>
+      {title && (
+        <div className={css.tooltip}>
+          {title}
+          <span className={css.tooltipArrow} />
+        </div>
+      )}
     </Component>
   );
 };
 
 Tooltip.defaultProps = {
   className: '',
+  title: '',
   as: 'span',
   align: '',
   containerRef: null,
 };
 
 Tooltip.propTypes = {
   className: PropTypes.string,
-  title: PropTypes.oneOfType([PropTypes.string, PropTypes.node]).isRequired,
+  title: PropTypes.node,
   children: PropTypes.node.isRequired,
   as: PropTypes.oneOfType([PropTypes.string, PropTypes.element, PropTypes.func]),
   align: PropTypes.oneOf(['', 'topLeft']),