fix: ensure parquet options for scanning are used from SessionState #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By casting the read record batch to the delta schema datafusion can read tables where the underlying parquet files can be cast to the desired schema.
HawaiianSpork
previously approved these changes
Jun 24, 2024
HawaiianSpork
force-pushed
the
schema_adapter
branch
2 times, most recently
from
27b9639 to
d48425e
Compare
alexwilcoxson-rel
dismissed
HawaiianSpork’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating the ParquetExec plan in DeltaScanBuilder. The parquet options on the ParquetExec are left with their default values. This PR uses the SessionState on the builder to clone the ParquetOptions from.
This allows you to create your SessionContext/SessionState with additional Parquet reader options enabled (row filter pushdown, page index, rog group bloom filter pruning, etc).
Related Issue(s)
Documentation