Checkpoint improvement #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both commits describe the specific fixes, but basically our checkpoint code was collecting too much into memory when it could iterate! :roller_coaster: With a test table: Before `Maximum resident set size (kbytes): 19964728` After `Maximum resident set size (kbytes): 4017132` Sponsored-by: [Scribd Inc](https://tech.scribd.com) --------- Signed-off-by: R. Tyler Croy <rtyler@brokenco.de> (cherry picked from commit c05931a)
For checkpoint buffers that cannot fit into the batch size the checkpoint will be written with an insufficient number of bytes. Unfortunately our tests didn't catch this and it only manifested on tables with very large transaction logs Signed-off-by: R. Tyler Croy <rtyler@brokenco.de> (cherry picked from commit 264a0ec)
The default batch size is too large to build an on-demand "large table" so the test is ignored by default Signed-off-by: R. Tyler Croy <rtyler@brokenco.de> (cherry picked from commit e19e21f)
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
gregott-rel
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.