Set compile string to output language extension #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
commented
Dec 11, 2018
| @@ -104,6 +105,8 @@ class RelayCompilerWebpackPlugin { | |||
| sourceParserName, | |||
| languagePlugin: language | |||
| }) | |||
|
|
|||
| this.languagePlugin = language | |||
There was a problem hiding this comment.
It wasn't obvious to me how I should pass the language output extension down to compile but I figured I'd just do it like this for now.
|
@koddsson thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @danielholmes 👋
I think passing
tsdown toRelayCompilerRunner.compilewhen compiling TypeScript and passingjswhen compiling JavaScript is needed when working with different languages. I had some errors at least when trying to use TypeScript and this fixes it. I also added the flow type for the plugin interface where applicable since I saw that it was currently being typed asany.Ref: #33