fix(google-pubsub): Make event data optional

src/lib/googlePubSub.spec.ts

@@ -305,16 +305,20 @@ describe('convertGooglePubSubMessage', () => {
       expect(event.data).toMatchObject(EVENT.data!);
     });
 
-    test('Message should be refused if data is missing', () => {
-      const invalidRequestBody = {
+    test('Should be empty if data is missing', () => {
+      const body = {
         ...requestBody,
-        message: { ...requestBody.message, data: undefined },
+
+        message: {
+          ...requestBody.message,
+          data: undefined,
+        },
       };
-      const invalidRequestBodySerialised = jsonSerialise(invalidRequestBody);
+      const bodySerialised = jsonSerialise(body);
 
-      expect(() =>
-        convertGooglePubSubMessage(headers, invalidRequestBodySerialised),
-      ).toThrowWithMessage(Error, 'Request body is not a valid PubSub message');
+      const event = convertGooglePubSubMessage(headers, bodySerialised);
+
+      expect(event.data).toBeUndefined();
     });
   });
 

src/lib/googlePubSub.ts

@@ -50,7 +50,7 @@ const pubSubBody = {
         publishTime: { type: 'string' },
       },
 
-      required: ['attributes', 'data', 'messageId', 'publishTime'],
+      required: ['attributes', 'messageId', 'publishTime'],
     },
   },
 
@@ -125,6 +125,7 @@ export function convertGooglePubSubMessage(_headers: Headers, body: Buffer): Clo
 
   if (isPubSubBody(bodyJson)) {
     const { message } = bodyJson;
+    const data = message.data === undefined ? undefined : Buffer.from(message.data!, 'base64');
     const extensionAttributes = filterExtensionAttributes(message.attributes);
     return new CloudEvent<Buffer>({
       specversion: message.attributes.specversion,
@@ -135,7 +136,7 @@ export function convertGooglePubSubMessage(_headers: Headers, body: Buffer): Clo
       time: message.publishTime,
       datacontenttype: message.attributes.datacontenttype,
       dataschema: message.attributes.dataschema,
-      data: Buffer.from(message.data, 'base64'),
+      data,
       ...extensionAttributes,
     });
   }