Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update service deployed version when manually refreshing via the GUI #279

Closed
samcro1967 opened this issue Jun 29, 2023 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@samcro1967
Copy link

Currently when you edit a service in the GUI and manually do a refresh of the deployed version, it updates in the edit dialog box, but the confirm button is not active. When you click cancel, the app is still showing as needing updated in the dashboard. Not sure if latest version is working the same way or not.

Is it possible to recognize the deployed version being updated when refreshed as a change, enabling the confirm button, and updating the dashboard accordingly?

image

@samcro1967 samcro1967 added the enhancement New feature or request label Jun 29, 2023
@JosephKav
Copy link
Collaborator

JosephKav commented Jun 29, 2023

Hmmm, I've just tested this again on 0.12.1 and refreshing the version if you don't change any of the params does refresh the version in the dashboard outside of the edit. I had two windows open and it updated the version in both windows.
Are you changing any vars in the Service you're refreshing? - You shouldn't have if the confirm is disabled. Odd

@JosephKav
Copy link
Collaborator

JosephKav commented Jun 29, 2023

Looking at the code for this now. I think it's because you've got semantic_versioning as non-default (false) for that Service. (I've got a fix for that coming in #272. Just finishing the tests now)

JosephKav added a commit that referenced this issue Jun 29, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 4, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 4, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 4, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 4, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 4, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 5, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 6, 2023
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
JosephKav added a commit that referenced this issue Jul 11, 2023
Features
* service: add /tags fallback to GitHub services (207e610), closes #275
* service: default service notify/command/webhook (08eb05f)
* service: support leading "v" in versions (e.g. v1.2.3) (bdab68d)
* web: lv url-commands, add regex index field (#274) (7def08c)

Bug Fixes
* db: switch to text for versions to keep trailing 0's (7289ce9)
* notify: missing defaults for shoutrrr type (4bdbf17)
* web: allow skip when command/webhook blocked by delay (4436d38)
* web: compare previous semantic_version state in version refreshes (3414a24), closes #279

master
JosephKav added a commit that referenced this issue Jul 11, 2023
Features
* service: add /tags fallback to GitHub services (207e610), closes #275
* service: default service notify/command/webhook (08eb05f)
* service: support leading "v" in versions (e.g. v1.2.3) (bdab68d)
* web: lv url-commands, add regex index field (#274) (7def08c)

Bug Fixes
* db: switch to text for versions to keep trailing 0's (7289ce9)
* notify: missing defaults for shoutrrr type (4bdbf17)
* web: allow skip when command/webhook blocked by delay (4436d38)
* web: compare previous semantic_version state in version refreshes (3414a24), closes #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants