Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for deployed version POST requests #397

Closed
dannytsang opened this issue May 6, 2024 · 4 comments · Fixed by #398
Closed

feat: Support for deployed version POST requests #397

dannytsang opened this issue May 6, 2024 · 4 comments · Fixed by #398
Labels
enhancement New feature or request

Comments

@dannytsang
Copy link

Is your feature request related to a problem? Please describe.
A way to send body data as part of the deployed version check. I have a service that uses graphql and the query resides in the body.

Describe the solution you'd like
An extra parameter to handle body data just like headers.

Describe alternatives you've considered
N/A

Additional context
N/A

@dannytsang dannytsang added the enhancement New feature or request label May 6, 2024
@JosephKav
Copy link
Collaborator

Hi Danny,
Could you give me an example of the query please? Are you sure it can't be done with headers/query params, cause having a body in a GET request isn't generally recommended.
Looking here, they put the

{
  me {
    name
  }
}

query into the url by adding ?query={me{name}} to it

@dannytsang
Copy link
Author

dannytsang commented May 6, 2024

Can I change my request to support POST please🙏

@JosephKav
Copy link
Collaborator

Yeah okay. I'll work on adding a method select to choose between GET and POST, and if POST is selected, give a field to set the Body

JosephKav added a commit that referenced this issue May 6, 2024
@JosephKav JosephKav linked a pull request May 6, 2024 that will close this issue
@JosephKav JosephKav changed the title feat: Support for Body In Deployed Version feat: Support for deployed version POST requests May 6, 2024
JosephKav added a commit that referenced this issue May 6, 2024
JosephKav added a commit that referenced this issue May 7, 2024
JosephKav added a commit that referenced this issue May 7, 2024
JosephKav added a commit that referenced this issue May 7, 2024
@JosephKav
Copy link
Collaborator

POST's for deployed versions should work in 0.18.0 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants