Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): custom favicon support #355

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

JosephKav
Copy link
Collaborator

settings:
  web:
    favicon:
      svg: URL  # favicon.svg
      png: URL  # apple-touch-icon.png

This also changes the 'Argus' icon in the top-left of the web UI

@JosephKav JosephKav added the enhancement New feature or request label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec7fa14) 98.67% compared to head (ef6becb) 98.67%.

❗ Current head ef6becb differs from pull request most recent head 7e234c0. Consider uploading reports for the commit 7e234c0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   98.67%   98.67%   +0.01%     
==========================================
  Files          87       87              
  Lines        8678     8693      +15     
==========================================
+ Hits         8562     8577      +15     
  Misses         90       90              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* bump @tanstack/react-query from 5.17.9 to 5.17.19
* bump @tanstack/react-query-devtools from 5.17.9 to 5.17.21
* bump @types/node from 20.10.8 to 20.11.10
* bump @types/react from 18.2.47 to 18.2.48
* bump date-fns from 3.2.0 to 3.3.1
* bump react-bootstrap from 2.9.2 to 2.10.0
* bump react-router-dom from 6.21.1 to 6.21.3
* bump follow-redirects from 1.15.2 to 1.15.4 (#348)
@JosephKav JosephKav force-pushed the 354-featweb-custom-favicon-support branch from ef6becb to 7e234c0 Compare January 30, 2024 01:29
@JosephKav JosephKav merged commit 013644d into master Jan 30, 2024
5 checks passed
@JosephKav JosephKav deleted the 354-featweb-custom-favicon-support branch January 30, 2024 01:33
JosephKav added a commit to release-argus/Website that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant