Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support env vars in some config vars #365

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Feb 17, 2024

"${ENV_VAR}" | "foo${ENV_VAR}"

  • latest_version.access_token
  • latest_version.url
  • latest_version.require.docker.username
  • latest_version.require.docker.token
  • deployed_version.basic_auth.username
  • deployed_version.basic_auth.password
  • deployed_version.headers.*.key
  • deployed_version.headers.*.value
  • deployed_version.url
  • notify.*.options.*
  • notify.*.params.*
  • notify.*.url_fields.*
  • webhook*.secret
  • webhook*.url

Also added

  • -web.basic-auth.username flag
  • -web.basic-auth.password flag

and support for

  • ARGUS_WEB_BASIC_AUTH_USERNAME
  • ARGUS_WEB_BASIC_AUTH_PASSWORD

"${ENV_VAR}" | "foo${ENV_VAR}"
* deployed_version.basic_auth.password
* deployed_version.basic_auth.username
* deployed_version.headers.*.key
* deployed_version.headers.*.value
* deployed_version.url
* latest_version.access_token
* latest_version.url
* latest_version.require.docker.token
* latest_version.require.docker.username
* notify.*.options.*
* notify.*.params.*
* notify.*.url_fields.*
* webhook.*.secret
* webhook.*.url

* -web.basic-auth.password flag
* -web.basic-auth.username flag

* ARGUS_WEB_BASIC_AUTH_USERNAME env
* ARGUS_WEB_BASIC_AUTH_PASSWORD env
@JosephKav JosephKav added the enhancement New feature or request label Feb 17, 2024
@JosephKav JosephKav linked an issue Feb 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dc3419) 98.73% compared to head (b25f55f) 98.74%.

❗ Current head b25f55f differs from pull request most recent head 1eccec9. Consider uploading reports for the commit 1eccec9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   98.73%   98.74%   +0.01%     
==========================================
  Files          87       87              
  Lines        6828     6878      +50     
==========================================
+ Hits         6741     6791      +50     
  Misses         61       61              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* bump tanstack/react-query from 5.17.19 to 5.22.2
* bump bootstrap from 5.3.2 to 5.3.3
* bump react-bootstrap from 2.10.0 to 2.10.1
* bump react-hook-form from 7.49.3 to 7.50.1
* bump react-router-dom from 6.21.3 to 6.22.1
@JosephKav JosephKav force-pushed the env-vars-in-config branch 10 times, most recently from c7d210b to 1eccec9 Compare February 22, 2024 11:07
@JosephKav JosephKav merged commit 40c0a00 into master Feb 22, 2024
7 checks passed
@JosephKav JosephKav deleted the env-vars-in-config branch February 22, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Ability to specify environment variables in config
1 participant