Fixing IIB KeyError when updating request state

[CLOUDDST-20361]
release-engineering · Sep 26, 2023 · 1362a34 · 1362a34
1 parent d5b6911
commit 1362a34
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/iib/workers/api_utils.py b/iib/workers/api_utils.py
@@ -169,7 +169,7 @@ def update_request(
             rv.text,
         )
         if exc_msg:
-            _exc_msg = exc_msg.format(**payload)
+            _exc_msg = exc_msg.format(**payload, request_id=request_id)
         else:
             _exc_msg = f'The worker failed to update the request {request_id}'
         raise IIBError(_exc_msg)

diff --git a/tests/test_workers/test_api_utils.py b/tests/test_workers/test_api_utils.py
@@ -86,7 +86,10 @@ def test_update_request_connection_failed(mock_session):
     'exc_msg, expected',
     (
         (None, 'The worker failed to update the request 3'),
-        ('Failed to set index_image={index_image}', 'Failed to set index_image=index-image:latest'),
+        (
+            'Failed to set index_image={index_image} on request {request_id}',
+            'Failed to set index_image=index-image:latest on request 3',
+        ),
     ),
 )
 @mock.patch('iib.workers.api_utils.requests_auth_session')