-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dependency issues #414
fix dependency issues #414
Conversation
package installation was failing on multiple systems including for py39 Signed-off-by: arewm <arewm@users.noreply.github.com>
@release-engineering/exd-guild-hello-operator |
@arewm I believe the IIB deployment is on py3.8. That's the reason the requirements file pertains to the same. Can I please ask if you have tested it on py3.8 and it works? |
The Travis CI has passed for 3.8. The requirements files have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should work in py38 too since the travisCI build succeeds. Approving this
@release-engineering/exd-guild-hello-operator Please speak up if you have any concerns with this change. I'll merge this by the end of this week if I receive no response from anyone :) |
I've tested it on devenv and it is working. (this PR with Py3.8) |
@lipoja, I run on a Mac (Intel). @yashvardhannanavati had me hopeful that I wouldn't run into issues because he runs on a Mac too, but that didn't turn out for me. :) The next step will be to try on an M1 whenever I get that computer next... |
package installation was failing on multiple systems including for py39
Issues encountered were with installing
pykerberos
installing
ruamel.yaml.clib
and
pg_config
The last one is what was failing on Python 3.9. For the first and last packages, I just updated the dependency to the latest. For the middle error, I added the dependency to
setup.py
.Updating
requests-kerberos
removed the dependency on the failing package that was no longer being maintained as the package moved off of that inv0.13.0
.Updating
psycopg2-binary
from2.8.4
to2.9.3
supports Python 3.9. The only notable removals from the tag descriptions are dropping support from Python 3.4/3.5 andmx.DateTime
(in version 2.9).Signed-off-by: arewm arewm@users.noreply.github.com