Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependency issues #414

Merged

Conversation

arewm
Copy link
Contributor

@arewm arewm commented Jul 12, 2022

package installation was failing on multiple systems including for py39

Issues encountered were with installing pykerberos

      10 warnings generated.
      creating build/lib.macosx-12-x86_64-cpython-38
      clang -bundle -undefined dynamic_lookup -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk build/temp.macosx-12-x86_64-cpython-38/src/base64.o build/temp.macosx-12-x86_64-cpython-38/src/kerberos.o build/temp.macosx-12-x86_64-cpython-38/src/kerberosbasic.o build/temp.macosx-12-x86_64-cpython-38/src/kerberosgss.o build/temp.macosx-12-x86_64-cpython-38/src/kerberospw.o -o build/lib.macosx-12-x86_64-cpython-38/kerberos.cpython-38-darwin.so -dynamic -Wl,-search_paths_first -lkrb5
      ld: warning: pointer not aligned at address 0x800E (_krb5_mech_oid + 4 from build/temp.macosx-12-x86_64-cpython-38/src/kerberos.o)
      ld: warning: pointer not aligned at address 0x8022 (_spnego_mech_oid + 4 from build/temp.macosx-12-x86_64-cpython-38/src/kerberos.o)
      ld: unaligned pointer(s) for architecture x86_64
      clang: error: linker command failed with exit code 1 (use -v to see invocation)
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> pykerberos

installing ruamel.yaml.clib

Collecting ruamel.yaml.clib>=0.1.2
ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    ruamel.yaml.clib>=0.1.2 from https://files.pythonhosted.org/packages/23/2e/79d684c6cfa50b593f47938fec86f7c5d0208e0ecd278eef2ff0e10889d3/ruamel.yaml.clib-0.2.6-cp38-cp38-macosx_10_9_x86_64.whl#sha256=a32f8d81ea0c6173ab1b3da956869114cae53ba1e9f72374032e33ba3118c233 (from ruamel-yaml==0.16.10->-r requirements-test.txt (line 498))

and pg_config

      Error: pg_config executable not found.

      pg_config is required to build psycopg2 from source.  Please add the directory
      containing pg_config to the $PATH or specify the full executable path with the
      option:

The last one is what was failing on Python 3.9. For the first and last packages, I just updated the dependency to the latest. For the middle error, I added the dependency to setup.py.

Updating requests-kerberos removed the dependency on the failing package that was no longer being maintained as the package moved off of that in v0.13.0.

Updating psycopg2-binary from 2.8.4 to 2.9.3 supports Python 3.9. The only notable removals from the tag descriptions are dropping support from Python 3.4/3.5 and mx.DateTime (in version 2.9).

Signed-off-by: arewm arewm@users.noreply.github.com

package installation was failing on multiple systems including for py39

Signed-off-by: arewm <arewm@users.noreply.github.com>
@yashvardhannanavati
Copy link
Collaborator

@release-engineering/exd-guild-hello-operator

@yashvardhannanavati
Copy link
Collaborator

@arewm I believe the IIB deployment is on py3.8. That's the reason the requirements file pertains to the same. Can I please ask if you have tested it on py3.8 and it works?

@arewm
Copy link
Contributor Author

arewm commented Jul 20, 2022

The Travis CI has passed for 3.8. The requirements files have 3.9 on them because they were generated with python 3.9 and not because that is the required version to install.

Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should work in py38 too since the travisCI build succeeds. Approving this

@yashvardhannanavati
Copy link
Collaborator

@release-engineering/exd-guild-hello-operator Please speak up if you have any concerns with this change. I'll merge this by the end of this week if I receive no response from anyone :)

@lipoja
Copy link
Contributor

lipoja commented Jul 26, 2022

I've tested it on devenv and it is working. (this PR with Py3.8)
@arewm May I ask on which OS did you get this failing installation error? I could not reproduce it (on F36 - py3.9; nor on RHEL UBI 8 - py3.9).

@arewm
Copy link
Contributor Author

arewm commented Jul 26, 2022

@lipoja, I run on a Mac (Intel). @yashvardhannanavati had me hopeful that I wouldn't run into issues because he runs on a Mac too, but that didn't turn out for me. :)

The next step will be to try on an M1 whenever I get that computer next...

@yashvardhannanavati yashvardhannanavati merged commit 169e28b into release-engineering:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants