Increase iib_api_timeout, iib_retry_delay and iib_retry_jitter defaul… #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@release-engineering/exd-guild-hello-operator PTAL |
yashvardhannanavati
force-pushed
the
iib_retry_tuning
branch
from
27b0648 to
0dd84db
Compare
lipoja
previously approved these changes
Aug 1, 2022
|
@yashvardhannanavati PR needs a rebase |
| @@ -349,8 +349,8 @@ The custom configuration options for the Celery workers are listed below: | |||
| `30s` (30 seconds). | |||
| * `iib_total_attempts` - the total number of attempts to make at trying a function relating to the | |||
| container registry before erroring out. This defaults to `5`. It's also used as the max number of attempts to buildah when receiving HTTP 50X errors. | |||
| * `iib_retry_delay` - the delay in seconds between retry attempts. It's just used for buildah when receiving HTTP 50X errors. This defaults to `4`. | |||
| * `iib_retry_jitter` - the extra seconds to be added on delay between retry attempts. It's just used for buildah when receiving HTTP 50X errors. This defaults to `2`. | |||
| * `iib_retry_delay` - the delay in seconds between retry attempts. It's just used for buildah when receiving HTTP 50X errors. This defaults to `5`. | |||
There was a problem hiding this comment.
Should we change this setting as well? It mentions buildah retries will be affected with this only
There was a problem hiding this comment.
The buildah retries happen too soon not allowing any network glitch to resolve. Hence I changed this too. Please let me know if I should revert it
There was a problem hiding this comment.
Nope. I don't mind this change, we can definitely keep it. :)
I wasn't aware that buildah retries also needed to be optimized.
…t values This will ensure that IIB backs off for a reasonable time before retrying and will also retry on timeout errors. Refers to CLOUDDST-14454
yashvardhannanavati
force-pushed
the
iib_retry_tuning
branch
from
552cfbb to
3903cb6
Compare
chandwanitulsi
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that IIB backs off for a reasonable time before retrying
and will also retry on timeout errors.
Refers to CLOUDDST-14454