enable customizations for podman-compose #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
force-pushed
the
master
branch
3 times, most recently
from
cc189e4 to
367ab43
Compare
|
https://app.travis-ci.com/github/release-engineering/iib/builds/255102904 is an example of the failure when the |
yashvardhannanavati
previously approved these changes
Sep 1, 2022
arewm
force-pushed
the
master
branch
3 times, most recently
from
9f4c562 to
b2675e8
Compare
arewm
force-pushed
the
master
branch
2 times, most recently
from
17d90b6 to
8c00e33
Compare
yashvardhannanavati
previously approved these changes
Sep 14, 2022
Signed-off-by: arewm <arewm@users.noreply.github.com>
yashvardhannanavati
approved these changes
Sep 14, 2022
This was referenced Sep 14, 2022
arewm
added a commit
to arewm/iib
that referenced
this pull request
Sep 15, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
pushed a commit
to arewm/iib
that referenced
this pull request
Sep 16, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
pushed a commit
to arewm/iib
that referenced
this pull request
Sep 16, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
added a commit
to arewm/iib
that referenced
this pull request
Sep 16, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
added a commit
to arewm/iib
that referenced
this pull request
Sep 16, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
added a commit
to arewm/iib
that referenced
this pull request
Sep 16, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
added a commit
to arewm/iib
that referenced
this pull request
Sep 27, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
added a commit
to arewm/iib
that referenced
this pull request
Sep 27, 2022
In release-engineering#421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
yashvardhannanavati
pushed a commit
that referenced
this pull request
Sep 27, 2022
In #421, I modified the context and paths to both go up a directory. That was an error. I should have just modified one. This provides the context to be the root directory so all paths are relative to that. Signed-off-by: arewm <arewm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @yashvardhannanavati for the initial contents of
podman.compose. I just wanted to help share it with others!I haven't added any validation to this (namely ensuring that
docker.composeis the content ofdocker-compose.yml), but this shouldn't be terribly hard to hook up to fail CI if false. I can also add content to the README if desired.Signed-off-by: arewm arewm@users.noreply.github.com