Add bundle_replacements parameter to regenerate_bundle #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
force-pushed
the
bundle-replacements
branch
4 times, most recently
from
a88c6a0 to
5c62d1e
Compare
yashvardhannanavati
requested review from
yashvardhannanavati and
chandwanitulsi
yashvardhannanavati
requested changes
Sep 14, 2022
arewm
force-pushed
the
bundle-replacements
branch
3 times, most recently
from
df21a4c to
ffd071a
Compare
arewm
requested review from
yashvardhannanavati
and removed request for
chandwanitulsi
|
@chandwanitulsi, I didn't mean to remove a requested review from you. Please feel free to review! :D |
| for old, new in bundle_replacements.items(): | ||
| if _is_bundle_image(old): | ||
| replacement_pullspecs[ImageName.parse(old)] = ImageName.parse(new) | ||
| _replace_csv_pullspecs(bundle_metadata, replacement_pullspecs) |
There was a problem hiding this comment.
Do we know what happens if the pullspec you are trying to replace is not present in the CSV? Will it throw an error?
There was a problem hiding this comment.
It won't throw an error. This is actually already tested with the test case I included --
bundle_replacements = {
'quay.io/operator/image@sha256:654321': 'quay.io/operator/image@sha256:123456',
'registry.access.company.com/operator/image@sha256:765432': 'foo.baz/image@sha256:234567',
}The first pullspec is present, the second isn't (at the time of doing the replacements).
Make the process easier to migrate the underlying database and update requirements files. Also updated the package dependencies to support building on aarch. Signed-off-by: arewm <arewm@users.noreply.github.com>
Adding support towards the specification of specific bundle replacements to perform when calling the `regenerate_bundle` API. Refers to CLOUDDST-14679 Signed-off-by: arewm <arewm@users.noreply.github.com>
Continuing to add support towards the specification of specific bundle replacements to perform when calling the `regenerate_bundle` API. In order to apply the bundle_replacements, a `perform_bundle_replacements` typed customization needs to be set for the organization. Refers to CLOUDDST-14790 Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
force-pushed
the
bundle-replacements
branch
from
ffd071a to
0ab3d4a
Compare
yashvardhannanavati
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support towards the specification of specific bundle replacements
to perform when calling the regenerate_bundle API.
Refers to CLOUDDST-14679 and CLOUDDST-14790
Replaces #424 to resolve the merge conflicts.
Signed-off-by: arewm arewm@users.noreply.github.com