Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy fix and enablement #477

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Mypy fix and enablement #477

merged 2 commits into from
Jan 12, 2023

Conversation

xDaile
Copy link
Contributor

@xDaile xDaile commented Jan 5, 2023

Fix for few mypy errors, and also enablement of mypy check.
Related to: https://issues.redhat.com/browse/CLOUDDST-16919

Mypy repaired bugs:

  • return inside of cycle removed
  • convert Optional[str] value to str value added, - str part has to be str as the return type is imported from flask,
  • add bundle-replacements to RegenerateBundleRequestResponse

Allowed mypy check

@xDaile xDaile force-pushed the mypy_fix_and_enablement branch 4 times, most recently from 3cc2829 to a967d14 Compare January 10, 2023 15:46
@xDaile
Allow mypy check
ef684c0 
Mypy errors were fixed too:
- remove return inside of cycle
- add bundle-replacements to RegenerateBundleRequestResponse
- add check for None in json_error
@xDaile xDaile force-pushed the mypy_fix_and_enablement branch from a967d14 to ef684c0 Compare January 10, 2023 15:58
@lipoja lipoja self-requested a review January 11, 2023 15:32
@lipoja
Copy link
Contributor

lipoja commented Jan 12, 2023

@xDaile Are you able to test it locally? Running at least add bundle?

@xDaile
Copy link
Contributor Author

xDaile commented Jan 12, 2023 •
edited
Loading

@lipoja
Yes, I was able to create-empty-index, I can also try other API calls, if needed.

@lipoja lipoja merged commit 568b6f1 into release-engineering:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandwanitulsi chandwanitulsi chandwanitulsi approved these changes

@lipoja lipoja lipoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xDaile @lipoja @chandwanitulsi