Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new API endpoint fbc-operations #482

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Create new API endpoint fbc-operations #482

merged 1 commit into from
Feb 3, 2023

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Jan 10, 2023

[CLOUDDST-16721]

@lipoja lipoja force-pushed the fbc_operations_api branch 3 times, most recently from 6e9aef2 to 5d5b94d Compare January 11, 2023 14:15
@lipoja lipoja force-pushed the fbc_operations_api branch 3 times, most recently from fca8d54 to d9c9f2f Compare January 13, 2023 14:43
chandwanitulsi
chandwanitulsi reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments, other than that looks good

@lipoja lipoja force-pushed the fbc_operations_api branch 2 times, most recently from 65d92b3 to ea0ebc3 Compare January 23, 2023 13:02
@lipoja lipoja marked this pull request as ready for review January 23, 2023 13:03
@lipoja lipoja requested a review from chandwanitulsi January 23, 2023 13:03
yashvardhannanavati
yashvardhannanavati requested changes Jan 23, 2023
View reviewed changes
iib/web/api_v1.py Outdated Show resolved Hide resolved
iib/web/api_v1.py Outdated Show resolved Hide resolved
iib/web/api_v1.py Outdated Show resolved Hide resolved
iib/web/migrations/versions/8d50f82f0be9_fbc_operations_api.py Outdated Show resolved Hide resolved
iib/web/migrations/versions/8d50f82f0be9_fbc_operations_api.py Outdated Show resolved Hide resolved
@lipoja lipoja force-pushed the fbc_operations_api branch from ea0ebc3 to e587b3e Compare January 24, 2023 10:07
xDaile
xDaile previously approved these changes Jan 24, 2023
View reviewed changes
yashvardhannanavati
yashvardhannanavati requested changes Jan 24, 2023
View reviewed changes
iib/web/models.py Outdated Show resolved Hide resolved
iib/web/models.py Show resolved Hide resolved
chandwanitulsi
chandwanitulsi reviewed Jan 25, 2023
View reviewed changes
iib/web/iib_static_types.py Show resolved Hide resolved
iib/web/models.py Show resolved Hide resolved
@lipoja lipoja force-pushed the fbc_operations_api branch from e587b3e to c5365a1 Compare January 25, 2023 12:51
chandwanitulsi
chandwanitulsi previously approved these changes Jan 26, 2023
View reviewed changes
@chandwanitulsi
Copy link
Contributor

@lipoja, when I run the fbc-operations api even without the worker part, the response I get doesn't have from_index or index_image fields, looks like something is missing

@lipoja lipoja force-pushed the fbc_operations_api branch 2 times, most recently from 8e5424c to 057c890 Compare January 31, 2023 13:56
yashvardhannanavati
yashvardhannanavati previously approved these changes Jan 31, 2023
View reviewed changes
iib/web/models.py Show resolved Hide resolved
iib/web/models.py Outdated Show resolved Hide resolved
@lipoja lipoja force-pushed the fbc_operations_api branch from 057c890 to 22bb77a Compare February 1, 2023 09:38
@lipoja lipoja requested review from chandwanitulsi, xDaile and yashvardhannanavati and removed request for xDaile February 1, 2023 09:39
chandwanitulsi
chandwanitulsi reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change,
other than that it looks okay and runs properly on dev-env

iib/web/models.py Show resolved Hide resolved
@lipoja lipoja force-pushed the fbc_operations_api branch from 22bb77a to db4dc80 Compare February 2, 2023 12:05
@chandwanitulsi
Copy link
Contributor

Hey @lipoja , I tested the API PR again on my dev-env I am still getting errors while using distribution_scope and build_tags (Yash checked as well and getting same errors)
can you please take a look at your dev-env again?

@yashvardhannanavati
Copy link
Collaborator

Hey @lipoja , I tested the API PR again on my dev-env I am still getting errors while using distribution_scope and build_tags (Yash checked as well and getting same errors) can you please take a look at your dev-env again?

I believe the distribution_scope error is expected, but as Tulsi mentioned, along with the build_tags error, I am unable to submit the same request twice. The second time, it gives an error for fbc_fragment

@lipoja lipoja force-pushed the fbc_operations_api branch from 6c3c688 to d749653 Compare February 3, 2023 15:02
@lipoja
Copy link
Contributor Author

lipoja commented Feb 3, 2023

@yashvardhannanavati @chandwanitulsi Thank you Tulsi for helping me to debug it. It looks like Git was telling me the Everything up-to-date when I was pushing my changes. Now I re-pushed my changes and everything should be working

@lipoja lipoja force-pushed the fbc_operations_api branch from d749653 to e039f4d Compare February 3, 2023 15:24
@lipoja lipoja merged commit 9d02899 into release-engineering:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandwanitulsi chandwanitulsi chandwanitulsi approved these changes

@xDaile xDaile xDaile left review comments

@yashvardhannanavati yashvardhannanavati yashvardhannanavati left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lipoja @chandwanitulsi @yashvardhannanavati @xDaile