Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rm API endpoint to work with both not opted-in and opted-in opertors #488

Merged

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Feb 6, 2023

No description provided.

@lipoja lipoja requested review from chandwanitulsi and yashvardhannanavati and removed request for chandwanitulsi February 6, 2023 14:05
@lipoja lipoja force-pushed the tweak_api_rm branch 3 times, most recently from 192d6b5 to a411cc3 Compare February 7, 2023 13:58
@lipoja lipoja marked this pull request as ready for review February 7, 2023 14:03
Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment, otherwise looks good

iib/workers/tasks/build.py Show resolved Hide resolved
@chandwanitulsi
Copy link
Contributor

Code LGTM, but while testing its failed on IIBError('config directory does not exist: /tmp/iib-emgeriaw/from_index/configs'), maybe it just needs makedir here as well
Building dev-env again to test

@yashvardhannanavati
Copy link
Collaborator

yashvardhannanavati commented Feb 7, 2023

Hi Jan, when I run this on my local,

curl -u: --negotiate -X POST -H "Content-Type: application/json" http://localhost:8080/api/v1/builds/rm -d '{"operators":["submariner"],"from_index":"registry-proxy.engineering.redhat.com/rh-osbs/iib-pub-pending:v4.11", "binary_image": "registry.redhat.io/openshift4/ose-operator-registry:v4.11"}'

it also fails with

[2023-02-07 22:39:22,972: ERROR/ForkPoolWorker-1] Task iib.workers.tasks.build.handle_rm_request[72b7ee73-2925-4c17-ada6-55260c971931] raised unexpected: IIBError('config directory does not exist: /tmp/iib-u6rnxy3l/from_index/configs') Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/celery/app/trace.py", line 451, in trace_task R = retval = fun(*args, **kwargs) File "/usr/local/lib/python3.8/site-packages/celery/app/trace.py", line 734, in __protected_call__ return self.run(*args, **kwargs) File "/src/iib/workers/tasks/utils.py", line 860, in wrapper return func(*args, **kwargs) File "/src/iib/workers/tasks/build.py", line 1095, in handle_rm_request merge_catalogs_dirs(catalog_from_db, catalog_from_index) File "/src/iib/workers/tasks/fbc_utils.py", line 86, in merge_catalogs_dirs raise IIBError(msg) iib.exceptions.IIBError: config directory does not exist: /tmp/iib-u6rnxy3l/from_index/configs

Just like Tulsi mentioned. Could you please check?

@lipoja lipoja force-pushed the tweak_api_rm branch 2 times, most recently from 63b801b to 54b636b Compare February 8, 2023 17:39
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks okay, it works after testing

@yashvardhannanavati
Copy link
Collaborator

@chandwanitulsi is following it up with the CI fix in a different PR

@yashvardhannanavati yashvardhannanavati merged commit 0670df7 into release-engineering:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants