Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for time tracking #507

Merged

Conversation

xDaile
Copy link
Contributor

@xDaile xDaile commented Mar 23, 2023

During local testing, I did find that almost all the time of the request is taken, by the following line.
rv = requests_auth_session.patch(request_url, json=payload, timeout=config.iib_api_timeout)
However, on my local environment, the time of the update_request method was still under ~0.7s, which is far from 30s.

As I am not able to test this, in an environment similar to what is in production/stage/QE, the best way to confirm my suspicion about the cause of timeout failing, would be probably to log the time of the patch method relative to the update_request method.

I will fill out the issue to revert these changes later after the cause of the timeout will be found.

Issue: https://issues.redhat.com/browse/CLOUDDST-15769

@xDaile xDaile force-pushed the log_update_request_times branch 2 times, most recently from bdd4344 to 4aaccce Compare March 30, 2023 10:54
@lipoja
Copy link
Contributor

lipoja commented Mar 30, 2023

@xDaile May I suggest to add more DEBUG log messages to patch_request method. So we have better understanding about time spend on tasks (e.g. processing parameters, get_or_create functions, ...)
So we know for example adding log before key_object = Image.get_or_create(key_value) we would know how many times it was called and and adding debug log after we could count the time from the log.
Basically go trough the code and put some comments around commands that might be time consuming.

@xDaile xDaile force-pushed the log_update_request_times branch 4 times, most recently from 570e764 to 7c297f0 Compare March 30, 2023 13:31
@xDaile xDaile force-pushed the log_update_request_times branch from 7c297f0 to 8d23230 Compare March 30, 2023 17:56
@lipoja lipoja self-requested a review March 31, 2023 13:47
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the jira in the description if we have a jira associated with this change?

@chandwanitulsi chandwanitulsi merged commit 2aa56e2 into release-engineering:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants