Fixing deprecation of operator in FBC image #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipoja
force-pushed
the
fix_deprecate_non_opted_fbc_image
branch
from
0a70da1 to
f99b179
Compare
lipoja
commented
Jun 9, 2023
lipoja
force-pushed
the
fix_deprecate_non_opted_fbc_image
branch
2 times, most recently
from
d4bcce8 to
a1b055d
Compare
yashvardhannanavati
approved these changes
Jun 13, 2023
lipoja
force-pushed
the
fix_deprecate_non_opted_fbc_image
branch
from
a1b055d to
9415964
Compare
| # Therefore we have to remove the directory before merging | ||
| for deprecate_bundle_pull_spec in deprecation_bundles: | ||
| # remove deprecated operators from FBC stored in index image | ||
| deprecate_bundle = get_image_label( |
There was a problem hiding this comment.
Minor suggestion: This could be deprecate_bundle_package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For correct behavior we have to remove all
deprecation_bundlesdirectories from FBC that may contain opted-in packages before overwriting catalogs (catalog from db and catalog from index). Otherwise already deprecated package is still served.