Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OpenTelemetry collector/exporter for dev-env #565

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Adding OpenTelemetry collector/exporter for dev-env #565

merged 1 commit into from
Sep 26, 2023

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Sep 13, 2023

  • update of docker-compose.yml and podman-compose.yml
  • added Jaeger to collect traces

[CLOUDDST-20308]

yashvardhannanavati
yashvardhannanavati previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I am not able to test it on my local because of some issue specific to my system. Could you please confirm if this was tested locally?

@lipoja
Copy link
Contributor Author

lipoja commented Sep 20, 2023

The changes look good to me. I am not able to test it on my local because of some issue specific to my system. Could you please confirm if this was tested locally?

Yes, I tested both. Podman and docker.

@zanssa zanssa requested a review from a team September 20, 2023 13:59
JAVGan
JAVGan reviewed Sep 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@lipoja lipoja requested review from JAVGan and zanssa September 22, 2023 08:12
@lipoja
Adding OpenTelemetry collector/exporter for dev-env
2109e88 
- update of docker-compose.yml and podman-compose.yml
- added Jaeger to collect traces

[CLOUDDST-20308]
@lipoja lipoja merged commit 88d7520 into release-engineering:master Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanssa zanssa zanssa approved these changes

@JAVGan JAVGan JAVGan approved these changes

@chandwanitulsi chandwanitulsi Awaiting requested review from chandwanitulsi

@xDaile xDaile Awaiting requested review from xDaile

@yashvardhannanavati yashvardhannanavati Awaiting requested review from yashvardhannanavati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lipoja @JAVGan @yashvardhannanavati @zanssa