Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non tagged index image in IIB_GRAPH_MODE_INDEX_ALLOW_LIST #661

Conversation

xDaile
Copy link
Contributor

@xDaile xDaile commented Apr 8, 2024

Related isssue: CLOUDDST-22149

This change allows us to specify index images without a tag to use with the graph_update_mode parameter.

@xDaile xDaile force-pushed the non_tag_index_image_in_graph_update_mode_list branch 9 times, most recently from e74e261 to 5f6a25c Compare April 9, 2024 12:10
@xDaile xDaile force-pushed the non_tag_index_image_in_graph_update_mode_list branch from 5f6a25c to fc12b7e Compare April 16, 2024 08:47
@xDaile xDaile force-pushed the non_tag_index_image_in_graph_update_mode_list branch from fc12b7e to 6a6ef7c Compare April 17, 2024 12:50
@xDaile xDaile force-pushed the non_tag_index_image_in_graph_update_mode_list branch from 0e6fd2a to b06380b Compare April 23, 2024 17:50
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Jan's comment should be addressed before merge and we should also ensure that in the release, IIB_GRAPH_MODE_INDEX_ALLOW_LIST is updated in playbooks

@xDaile
Copy link
Contributor Author

xDaile commented Apr 25, 2024

lgtm, Jan's comment should be addressed before merge and we should also ensure that in the release, IIB_GRAPH_MODE_INDEX_ALLOW_LIST is updated in playbooks

We do not need to update IIB_GRAPH_MODE_INDEX_ALLOW_LIST exactly before merge, as the solution will also work with the current config.

@chandwanitulsi
Copy link
Contributor

lgtm, Jan's comment should be addressed before merge and we should also ensure that in the release, IIB_GRAPH_MODE_INDEX_ALLOW_LIST is updated in playbooks

We do not need to update IIB_GRAPH_MODE_INDEX_ALLOW_LIST exactly before merge, as the solution will also work with the current config.

Not before merge, before the release or create another issue to update the config in playbook, otherwise we might forget to update

@xDaile
Copy link
Contributor Author

xDaile commented Apr 25, 2024

lgtm, Jan's comment should be addressed before merge and we should also ensure that in the release, IIB_GRAPH_MODE_INDEX_ALLOW_LIST is updated in playbooks

We do not need to update IIB_GRAPH_MODE_INDEX_ALLOW_LIST exactly before merge, as the solution will also work with the current config.

Not before merge, before the release or create another issue to update the config in playbook, otherwise we might forget to update

Opened Gitlab MR with updated config (If we merge Gitlab MR first or together with this PR, we do not need to think of this during the next release).

@xDaile xDaile merged commit e33e29e into release-engineering:master Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants