-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non tagged index image in IIB_GRAPH_MODE_INDEX_ALLOW_LIST #661
Allow non tagged index image in IIB_GRAPH_MODE_INDEX_ALLOW_LIST #661
Conversation
e74e261
to
5f6a25c
Compare
5f6a25c
to
fc12b7e
Compare
fc12b7e
to
6a6ef7c
Compare
0e6fd2a
to
b06380b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, Jan's comment should be addressed before merge and we should also ensure that in the release, IIB_GRAPH_MODE_INDEX_ALLOW_LIST is updated in playbooks
We do not need to update IIB_GRAPH_MODE_INDEX_ALLOW_LIST exactly before merge, as the solution will also work with the current config. |
Not before merge, before the release or create another issue to update the config in playbook, otherwise we might forget to update |
Opened Gitlab MR with updated config (If we merge Gitlab MR first or together with this PR, we do not need to think of this during the next release). |
Related isssue: CLOUDDST-22149
This change allows us to specify index images without a tag to use with the graph_update_mode parameter.