Fix OTEL issues when dealing with unsupported objects #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit detects a typical IIB API response, which consists of a
tuple with a Flask.Response object and the HTTP code.
Example:
```
def add_bundles() -> Tuple[flask.Response, int]:
...
return flask.jsonify(request.to_json()), 200
```
With this we no longer see the following messages in IIB-API logs:
```
Invalid type Response in attribute 'result' value sequence.
Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or None
```
Refers to CLOUDDST-23028
This commit changes the `else` condition from `instrument_tracing` so any object which is not properly mapped gets converted into `String` before sending the dictionary to the span. With this we expect to no longer have an OTEL unsupported type being passed as a span value. Refers to CLOUDDST-23028
xDaile
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the OTEL
instrument_tracingmethod to crash when dealing with complex types.It has the following changes:
First, it detects a typical IIB API response, which consists of a tuple with a Flask.Response object and the HTTP code.
Example:
Then, it also changes the execution from the
elsecondition oninstrument_tracingso any object which is not properly mapped gets converted intoStringbefore being sent as a dictionary value to the OTELspan_result.With this we no longer see the following messages in IIB-API logs:
Refers to CLOUDDST-23028