NCL5481 - dependencyOverride and deprecated properties

[rnc]

No description provided.

[codecov-io]

Codecov Report

Merging #744 into master will increase coverage by 0.02%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #744      +/-   ##
============================================
+ Coverage     81.83%   81.85%   +0.02%     
- Complexity     1439     1443       +4     
============================================
  Files           104      104              
  Lines          5318     5325       +7     
  Branches        924      923       -1     
============================================
+ Hits           4352     4359       +7     
  Misses          600      600              
  Partials        366      366

Impacted Files	Coverage Δ	Complexity Δ
...commonjava/maven/ext/core/ManipulationSession.java	92.3% <ø> (ø)	33 <0> (ø)	⬇️
...g/commonjava/maven/ext/core/state/PluginState.java	88.67% <ø> (ø)	16 <0> (ø)	⬇️
...rc/main/java/org/commonjava/maven/ext/cli/Cli.java	69.91% <ø> (-0.49%)	21 <0> (-3)
...mmonjava/maven/ext/manip/ManipulatingEventSpy.java	76.08% <ø> (-1.92%)	6 <0> (-2)
...commonjava/maven/ext/core/ManipulationManager.java	88.11% <100%> (+2.07%)	28 <12> (+9)	⬆️
...ava/maven/ext/core/impl/DependencyManipulator.java	86.15% <100%> (ø)	61 <0> (ø)	⬇️
...mmonjava/maven/ext/core/state/DependencyState.java	89.65% <66.66%> (ø)	23 <7> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10a19e...6bd1e3b. Read the comment docs.

[rnc]

Still need to do documentation!

[vibe13]

Looks good to me! +1 to deprecate the dependencyExclusion property, and also to throw an exception when usng deprecated properties (without enabling the use of it). I would not have chosen it (instead relying on warnings), but this is the only way to make sure that builds will start converting to not deprecated properties or be aware about the use of it. We will probably need to sanitize them in the build configs, but anyway, everything looks good to me! Thanks!