Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classifier and colour to dependency output. Make tests pme versio… #796

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Oct 7, 2020

…n independent

isPlugin ? "" : scope);
}
}
}
else if (printManipulatorOrder)
{
System.out.println ("Manipulator order is:");
System.out.println ("\u001B[32mManipulator order is:\033[0m");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking maybe we had Jansi to help with this, but it's only in test scope org.fusesource.jansi:jansi:jar:1.13:test.

Copy link
Member

@dwalluck dwalluck Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing if we wait for picocli to go in then we could use org.fusesource.jansi.AnsiConsole.

Copy link
Contributor Author

@rnc rnc Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems excessive to add jansi for two lines of code (and jansi is not in the current dependencies list).

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #796 into master will increase coverage by 15.31%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #796       +/-   ##
=============================================
+ Coverage     83.16%   98.48%   +15.31%     
+ Complexity     1855        1     -1854     
=============================================
  Files           115        1      -114     
  Lines          6928       66     -6862     
  Branches       1209        0     -1209     
=============================================
- Hits           5762       65     -5697     
+ Misses          678        1      -677     
+ Partials        488        0      -488     
Impacted Files Coverage Δ Complexity Δ
...g/commonjava/maven/ext/core/state/PluginState.java
...ava/maven/ext/core/impl/RelocationManipulator.java
.../commonjava/maven/ext/common/json/ModulesItem.java
...ava/maven/ext/core/state/ParentInjectionState.java
...ven/ext/core/impl/ProfileInjectionManipulator.java
...va/maven/ext/core/state/ProfileInjectionState.java
...va/org/commonjava/maven/ext/core/impl/Version.java
...mmonjava/maven/ext/integrationtest/ITestUtils.java
...rg/commonjava/maven/ext/common/util/JSONUtils.java
...main/java/org/commonjava/maven/ext/io/ModelIO.java
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637f72c...8d0d4fa. Read the comment docs.

@rnc rnc merged commit 9dd0203 into release-engineering:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants